Closed Bug 797112 Opened 7 years ago Closed 7 years ago

we have a call to dm.checkCmd and that api doesn't exist anymore

Categories

(Testing :: Mochitest, defect)

ARM
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: jmaher, Assigned: jmaher)

Details

Attachments

(1 file)

in runtestsremote.py we have a call to:
        if (options.dm_trans == 'adb' and options.robocopPath):
          dm.checkCmd(["install", "-r", os.path.join(options.robocopPath, "robocop.apk")])


This needs to work and we can simply change the checkCmd to:
          dm._checkCmd(["install", "-r", os.path.join(options.robocopPath, "robocop.apk")])

I believe we are changing this yet again this week, so I have cc'd folks who are interested.
Even better would be to replace this with a call to installApp, at least once bug 792072 is fixed. Your change is good for now though.
in testing this, we found that we were referencing self.localLog before it was defined which was causing an exception when we didn't run any tests.  So both of these issues are handled in this patch.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #667487 - Flags: review?(wlachance)
Comment on attachment 667487 [details] [diff] [review]
fix checkCmd and missing localLog (1.0)

LGTM
Attachment #667487 - Flags: review?(wlachance) → review+
https://hg.mozilla.org/mozilla-central/rev/2622aa008fe9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.