797129 - Root UncachedInlineCall in JM

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

Pair of unrooted vars.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Small JM rooting fix

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 667162 [details] [diff] [review]
Small JM rooting fix

Review of attachment 667162 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/methodjit/InvokeHelpers.cpp
@@ +279,5 @@
>  {
>      JSContext *cx = f.cx;
>      CallArgs args = CallArgsFromSp(argc, f.regs.sp);
> +    RootedFunction newfun(cx, args.callee().toFunction());
> +    HandleScript newscript = newfun->script();

I think I have this hunk.  I'm currently changing JSFunction::script() to return a Return<JSScript*>, since Nick made me aware of the potential lifetime issues.

Go ahead and get this in if you need it: I'll rebase.

Comment 3

[Steve Fink [:sfink] [:s:]]

Cleaning up bugs. I won't be committing this, I'll wait for terrence's commit.