797132 - [Settings] Alert Tones should not included in the radio button for Rintones

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

## Environment :
Otoro phone, build 2012-10-02 us
Taken from default.xml in b2g-distro: 
* "platform_build" revision= 795261940c8b11fb7dddd7a8e9dd8561fdc4fb64
* "gaia" revision= 3e360f0875e519743e2ce3159cbb035d5e8334e1 
* "releases-mozilla-central" revision= 4914d55691e8f602f4275d614183a2cde6aa69db
* "gonk-misc" revision= 202d2c62443c098b125e5d9d7b42226d98230e44
  
## Repro :
1. go to settings -> Sound -> Call
2. select Alert Tones - Low Bit

## Expected :
1. The ringtones and Alert tones are on two separate radio buttons

## Actual :
1. the ringtone and alert tones are on the same radio button
2. when clicking done and dialing to the phone, no sound is heard even though the sound for ringtone is set to on.

## Note :

Comment 1

[Evelyn Hung]

Attachment: correct the wrong alert tones' name

Comment 2

[Evelyn Hung]

Comment on attachment 673130 [details]
correct the wrong alert tones' name

Add a 'beep' string to fix this bug.
PR here: https://github.com/mozilla-b2g/gaia/pull/5893

Comment 3

[Evelyn Hung]

Comment on attachment 673130 [details]
correct the wrong alert tones' name

I found the string freeze deadline of Settings app is postponed. so assign yuren back as my reviewer.

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 673130 [details]
correct the wrong alert tones' name

This pull request fixed the bug which has no dialing sound with "Alert Tones - Low Bit" (rename to "beep beep" in this pull request).

about the two radio button groups: in the design spec, there is only one radio button group in the sound setting. please refer page 6 of the spec https://www.dropbox.com/sh/ygwfxk6chpshxdj/qVCvUXWOeG/Apps/Settings/R1_Personalization_v3.pdf

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Merged pull request.
https://github.com/mozilla-b2g/gaia/pull/5893

Comment 6

[Rebecca Billings [:rbillings]]

Verified on the 10/31 otoro us build, ringtones and alerts are separated and both sound.