Closed Bug 797177 Opened 7 years ago Closed 7 years ago

testing/mochitest/ broken after changset 14cf58aff2ec checkCmdAs


(Testing :: Mochitest, defect)

Not set


(Not tracked)



(Reporter: dchanm+bugzilla, Assigned: dchanm+bugzilla)



(2 files, 2 obsolete files)

DeviceManagerADB was recently refactored and checkCmdAs was renamed to _checkCmdAs. still uses checkCmdAs which results in an error when trying to run emulator tests
Attached patch change checkCmdAs to _checkCmdAs (obsolete) — Splinter Review
Attachment #667211 - Flags: review?(mdas)
Comment on attachment 667211 [details] [diff] [review]
change checkCmdAs to _checkCmdAs

There is more than needs to be fixed. I'll update the patch once I figure out what else is needed.
Attachment #667211 - Attachment is obsolete: true
Attachment #667211 - Flags: review?(mdas)
runCmd in build/mobile/ also needed to be updated. works for me with the attached patch.
Attachment #667218 - Flags: review?(ahalberstadt)
Comment on attachment 667218 [details] [diff] [review]
fix v2 [checked in]

Review of attachment 667218 [details] [diff] [review]:

Thanks! I have an upcoming patch that will fix this properly (i.e by not using the private methods), but it might be a few days out yet. Good to have this in the meantime.
Attachment #667218 - Flags: review?(ahalberstadt) → review+
I don't have commit access. We can either land this or wait for your patch. I'm not blocked on testing since I've made the local changes.
Keywords: checkin-needed
I'll land this today; the unittests are all broken in CI, so the faster we can fix them the better, even with a temporary workaround.
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Attached patch Fix missed calls to checkCmd (obsolete) — Splinter Review
Crap, looks like we missed some calls to checkCmd in
Attachment #668565 - Flags: review?(mhabicher)
Resolution: FIXED → ---
Comment on attachment 668565 [details] [diff] [review]
Fix missed calls to checkCmd

Review of attachment 668565 [details] [diff] [review]:

Attachment #668565 - Flags: review?(mhabicher) → review+
Attachment #668565 - Attachment is obsolete: true
Attachment #667218 - Attachment description: fix v2 → fix v2 [checked in]
Comment on attachment 668579 [details] [diff] [review]
Forgot to add commit message to last patch [checked in]
Attachment #668579 - Attachment description: Forgot to add commit message to last patch - Check this in → Forgot to add commit message to last patch [checked in]
Closed: 7 years ago7 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.