If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

searching imap messages for body search terms offline doesn't work.

VERIFIED FIXED in mozilla0.9.1

Status

SeaMonkey
MailNews: Backend
P3
normal
VERIFIED FIXED
17 years ago
6 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

Trunk
mozilla0.9.1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta1+]patch r=naving sr=sspitzer a= blizzard@mozilla.org)

Attachments

(6 attachments)

(Assignee)

Description

17 years ago
If you're offline and do a search on message bodies in an imap folder, you won't
get hits. 4x would apparently search the offline message bodies of the messages
it had offline bodies for.
(Assignee)

Comment 1

17 years ago
nominating for beta (though this would have to be prioritized lower than other
things)
Status: NEW → ASSIGNED
Keywords: nsbeta1
QA Contact: esther → laurel

Comment 2

17 years ago
moving to 0.9.2
Priority: -- → P3
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9.2
(Assignee)

Comment 3

17 years ago
Created attachment 35921 [details] [diff] [review]
search part of proposed fix
(Assignee)

Comment 4

17 years ago
Created attachment 35922 [details] [diff] [review]
base/util part of patch
(Assignee)

Comment 5

17 years ago
Created attachment 35923 [details] [diff] [review]
news part of diff
(Assignee)

Comment 6

17 years ago
Created attachment 35924 [details] [diff] [review]
imap part of patch
(Assignee)

Comment 7

17 years ago
request for code review. Also, Scott, if this patch doesn't get into the first
beta, users won't be able to do body searches on offline stores created with the
beta even when the final release comes out, so if possible, it would be great to
get this into the beta. It only affects body search and download of message
bodies for offline use, and is pretty safe.
I'll do some reviewing.  anyway to get one giant diff?
(Assignee)

Comment 9

17 years ago
most of the diffs are small - I have so much other stuff in my tree that I can't
checkin that I didn't want to have to do even more editing of the diffs :-(

Comment 10

17 years ago
r=naving, as long as you have tested NS_LINEBREAK_LEN
sr=sspitzer, but switch from NS_LINEBREAK_LEN to MSG_LINEBREAK_LEN to be consistent.

Comment 12

17 years ago
ok, moving to 0.9.1
Target Milestone: mozilla0.9.2 → mozilla0.9.1

Comment 13

17 years ago
a= blizzard@mozilla.org (noted in mail, just bringing the bug up to date)

Updated

17 years ago
Whiteboard: [nsbeta1+] → [nsbeta1+]patch r=naving sr=sspitzer a= blizzard@mozilla.org

Comment 14

17 years ago
Moving back to m.9.2.  With Asa's a= you can probably still check in.  Fix in
hand does not equal beta stopper.
Target Milestone: mozilla0.9.1 → mozilla0.9.2
(Assignee)

Comment 15

17 years ago
Cc'ing Asa since I guess Blizzard isn't sufficient?

Comment 16

17 years ago
moving back.  It's been given an a= by someone on driver's.
Target Milestone: mozilla0.9.2 → mozilla0.9.1
I've applied the patches (the imap one needed some tweaking to get it to
apply).  

I'll attach a complete patch by creating a patch from my tree.
Created attachment 36100 [details] [diff] [review]
the complete patch
Created attachment 36101 [details]
the complete patch, plus NS_LINEBREAK_LEN -> MSG_LINEBREAK_LEN
(Assignee)

Comment 20

17 years ago
fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 21

17 years ago
OK using may31 commercial trunk builds: mac OS 9.0, win98, linux rh6.2
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.