79723 - searching imap messages for body search terms offline doesn't work.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect, P3)

Description

[David :Bienvenu]

If you're offline and do a search on message bodies in an imap folder, you won't
get hits. 4x would apparently search the offline message bodies of the messages
it had offline bodies for.

Comment 1

[David :Bienvenu]

nominating for beta (though this would have to be prioritized lower than other
things)

Comment 2

[scottputterman]

moving to 0.9.2

Comment 3

[David :Bienvenu]

Attachment: search part of proposed fix

Comment 4

[David :Bienvenu]

Attachment: base/util part of patch

Comment 5

[David :Bienvenu]

Attachment: news part of diff

Comment 6

[David :Bienvenu]

Attachment: imap part of patch

Comment 7

[David :Bienvenu]

request for code review. Also, Scott, if this patch doesn't get into the first
beta, users won't be able to do body searches on offline stores created with the
beta even when the final release comes out, so if possible, it would be great to
get this into the beta. It only affects body search and download of message
bodies for offline use, and is pretty safe.

Comment 8

[(not reading, please use [e-mail] instead)]

I'll do some reviewing.  anyway to get one giant diff?

Comment 9

[David :Bienvenu]

most of the diffs are small - I have so much other stuff in my tree that I can't
checkin that I didn't want to have to do even more editing of the diffs :-(

Comment 10

[Navin Gupta]

r=naving, as long as you have tested NS_LINEBREAK_LEN

Comment 11

[(not reading, please use [e-mail] instead)]

sr=sspitzer, but switch from NS_LINEBREAK_LEN to MSG_LINEBREAK_LEN to be consistent.

Comment 12

[scottputterman]

ok, moving to 0.9.1

Comment 13

[Asa Dotzler [:asa]]

a= [e-mail] (noted in mail, just bringing the bug up to date)

Comment 14

[selmer (gone)]

Moving back to m.9.2.  With Asa's a= you can probably still check in.  Fix in
hand does not equal beta stopper.

Comment 15

[David :Bienvenu]

Cc'ing Asa since I guess Blizzard isn't sufficient?

Comment 16

[scottputterman]

moving back.  It's been given an a= by someone on driver's.

Comment 17

[(not reading, please use [e-mail] instead)]

I've applied the patches (the imap one needed some tweaking to get it to
apply).  

I'll attach a complete patch by creating a patch from my tree.

Comment 18

[(not reading, please use [e-mail] instead)]

Attachment: the complete patch

Comment 19

[(not reading, please use [e-mail] instead)]

Attachment: the complete patch, plus NS_LINEBREAK_LEN -> MSG_LINEBREAK_LEN

Comment 20

[David :Bienvenu]

fix checked in.

Comment 21

[laurel]

OK using may31 commercial trunk builds: mac OS 9.0, win98, linux rh6.2