Marking a task completed with no task selected causes task list to scroll to an invalid row

RESOLVED FIXED in 1.9

Status

Calendar
Tasks
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mmecca, Assigned: mmecca)

Tracking

unspecified

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
STR:

1) Add enough tasks to allow for scrolling in a task list.
2) Restart Thunderbird.
3) Scroll down in the task list without selecting a task.
4) Click a task completion checkbox.

Results:

The task list attempts to scroll to an invalid index before the first task in the list, displaying "false" for the task title. Error console shows multiple instances of:

Error: TypeError: item is undefined
Source file: chrome://calendar/content/calendar-task-tree.xml
Line: 510
(Assignee)

Comment 1

5 years ago
Created attachment 667940 [details] [diff] [review]
Fix v1

Makes sure we don't try to scroll to a negative row.
Attachment #667940 - Flags: review?(philipp)
Comment on attachment 667940 [details] [diff] [review]
Fix v1

Review of attachment 667940 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp. This seems safe for beta/aurora too.
Attachment #667940 - Flags: review?(philipp)
Attachment #667940 - Flags: review+
Attachment #667940 - Flags: approval-calendar-beta+
Attachment #667940 - Flags: approval-calendar-aurora+
(Assignee)

Comment 3

5 years ago
comm-central - https://hg.mozilla.org/comm-central/rev/b7e8c7c369f9
comm-aurora - https://hg.mozilla.org/releases/comm-aurora/rev/1901ab057b72
comm-beta - https://hg.mozilla.org/releases/comm-beta/rev/12beb6415d46
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.9
You need to log in before you can comment on or make changes to this bug.