Last Comment Bug 797251 - Marking a task completed with no task selected causes task list to scroll to an invalid row
: Marking a task completed with no task selected causes task list to scroll to ...
Status: RESOLVED FIXED
:
Product: Calendar
Classification: Client Software
Component: Tasks (show other bugs)
: unspecified
: All All
: -- normal (vote)
: 1.9
Assigned To: Matthew Mecca [:mmecca]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-02 20:46 PDT by Matthew Mecca [:mmecca]
Modified: 2012-10-25 06:11 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Fix v1 (1.41 KB, patch)
2012-10-04 06:26 PDT, Matthew Mecca [:mmecca]
philipp: review+
philipp: approval‑calendar‑aurora+
philipp: approval‑calendar‑beta+
Details | Diff | Review

Description Matthew Mecca [:mmecca] 2012-10-02 20:46:24 PDT
STR:

1) Add enough tasks to allow for scrolling in a task list.
2) Restart Thunderbird.
3) Scroll down in the task list without selecting a task.
4) Click a task completion checkbox.

Results:

The task list attempts to scroll to an invalid index before the first task in the list, displaying "false" for the task title. Error console shows multiple instances of:

Error: TypeError: item is undefined
Source file: chrome://calendar/content/calendar-task-tree.xml
Line: 510
Comment 1 Matthew Mecca [:mmecca] 2012-10-04 06:26:18 PDT
Created attachment 667940 [details] [diff] [review]
Fix v1

Makes sure we don't try to scroll to a negative row.
Comment 2 Philipp Kewisch [:Fallen] 2012-10-08 09:35:58 PDT
Comment on attachment 667940 [details] [diff] [review]
Fix v1

Review of attachment 667940 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp. This seems safe for beta/aurora too.

Note You need to log in before you can comment on or make changes to this bug.