797314 - Strange artifacts on some sites

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

If I set "gfx.direct2d.disabled" to true, then the problem does not happen.


Reproducible: Always


Steps to Reproduce:
1. Start Nightly
2. Open http://staraoliwa.pl/ or http://grupa-ratowania-poziomu.wykop.pl/



Regression Window:
Works:
https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win64/1349195957/firefox-18.0a1.en-US.win64-x86_64.installer.exe

Fails:
https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win64/1349198417/firefox-18.0a1.en-US.win64-x86_64.installer.exe

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c0ef7fe877d2&tochange=bca6d709dba2

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

probably triggered by:
Bug #778367 - [Azure] Minimize intermediate surface size used by push/popgroup

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

google search is also affected as many other sites ;p

Comment 3

[Alice0775 White]

I can confirm on youtube.com.
Setting gfx.content.azure.enabled=false helps.

Steps to reproduce:
 1. Open http://www.youtube.com/watch?v=55s3T7VRQSc

Actual results:
  Missing images and texts to render.
  After mouse hover over empty area, then the missing items appears

Comment 4

[Bas Schouten (:bas.schouten)]

Ugh, we really need a simplified testcase here :(

Comment 5

[Alice0775 White]

Attachment: reduced html

mouse hover over gray area

Comment 6

[Bas Schouten (:bas.schouten)]

I've found the bug, looks like I ruined a merge and have a potential bug, patch incoming.

Comment 7

[Bas Schouten (:bas.schouten)]

Attachment: Make sure we push only once and copy the full surface on PushGroupAndCopyBackground

Comment 10

[Brian Carpenter [:geeknik]]

Bas, I filed Bug 795467 on 9/28 that may/may not be related, if you could take a look.

Comment 11

[Bas Schouten (:bas.schouten)]

(In reply to Brian Carpenter [:geeknik] from comment #10)
> Bas, I filed Bug 795467 on 9/28 that may/may not be related, if you could
> take a look.

I doubt it.

Comment 12

[Jim Mathies [:jimm]]

possible dupe: bug 797549

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Please include a link to the inbound changeset when landing there. Also, is there any way to test this?
https://hg.mozilla.org/integration/mozilla-inbound/rev/cfa23be4f73c

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cfa23be4f73c

Comment 15

[Alfred Kayser]

Note, not just sites are affected. Some themes are also troubled by this, for example Nautipolis and Walnut. Just open a menu with short-cuts for example.
I hope that this is the fix to that also.

Comment 17

[Daniel]

Ther are still some overlays artefacts on h5ai web gui
http://i.imgur.com/pEWNf.png
check those sites for example:
http://xhmikosr.1f0.de/mpc-hc/?folder=bXBjLWhj
http://larsjung.de/h5ai/sample/

My build: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 ID:20121004030525

Comment 19

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Thank you! Artifacts are gone.
Marking as VERIFIED FIXED.

Using latest build from mozilla-inbound-win64 FYI
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:18.0) Gecko/18.0 Firefox/18.0
ID:20121004235827

Comment 20

[Bas Schouten (:bas.schouten)]

Comment on attachment 667509 [details] [diff] [review]
Make sure we push only once and copy the full surface on PushGroupAndCopyBackground

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 778367
User impact if declined: Corrupt rendering
Testing completed (on m-c, etc.): Aurora testing
Risk to taking this patch (and alternatives if risky): Dee bug 778367
String or UUID changes made by this patch: None

Comment 21

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 667509 [details] [diff] [review]
Make sure we push only once and copy the full surface on PushGroupAndCopyBackground

Please land this asap so it's in tomorrow's Beta.

Comment 22

[Bas Schouten (:bas.schouten)]

http://hg.mozilla.org/releases/mozilla-beta/rev/abe25ac44906

Comment 23

[u279076]

:Virtual, could you please check the latest Firefox 17 Beta is fixed as well?

Comment 24

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Can't reproduce it on Mozilla Firefox 17 Beta 4 (Portable), so looks fixed :)

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0
buildID: 20121031065642
Source: Built from http://hg.mozilla.org/releases/mozilla-beta/rev/486335dcb4a2

Comment 25

[u279076]

Thanks :Virtual. If this starts happening again, please file a new bug and mark it as dependent on this one.