79733 - pruthr.c using incorrect internal NSPR calls

Status: VERIFIED FIXED

(NSPR :: NSPR, defect, P1)

Description

[Mike Kaply [:mkaply]]

pruthr.c is using _MD_NEW_LOCK and _MD_FREE_LOCK when it 
should be using _PR_MD_NEW_LOCK and _PR_MD_FREE_LOCK.

This prevents platforms from implementing these APIs as 
functions - they have to implement them as #defines in a 
header.

Diff attached.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Change _MD_ calls to _PR_MD calls

Comment 2

[Wan-Teh Chang]

We should fix this, but using the _MD_ calls does not
prevent you from implementing these APIs as functions.

You can take a look at _MD_GET_INTERVAL and _MD_CREATE_FILE_MAP
in mozilla/nsprpub/pr/include/md/_os2.h as examples.

Comment 3

[Mike Kaply [:mkaply]]

I understand what you are saying but it does not link. I 
get unresolved externals for the _MD_ calls without this 
change. You can see our changes in 81666.

Comment 4

[Mike Kaply [:mkaply]]

I need to up the severity on this.

We have new semaphore code that we want to drop that improves OS/2 performance 
big time.

It relies on this bug and 81666.

Comment 5

[Wan-Teh Chang]

I reviewed the attached patch.  It is good.

Larry, could you please check in the patch on the trunk
and NSPRPUB_CLIENT_BRANCH of NSPR today?

Comment 6

[larryh (gone)]

Checked in fix on the tip of tree.

Comment 7

[larryh (gone)]

parts reviewed by wtc, larryh.
Checked in on NSPRPUB_CLIENT_BRANCH.

Comment 8

[larryh (gone)]

marking fixed.

Comment 9

[Mike Kaply [:mkaply]]

Code change went in.