Closed Bug 797340 Opened 7 years ago Closed 7 years ago

Upgrade mach_override

Categories

(Core :: XPCOM, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: espindola, Assigned: espindola)

Details

Attachments

(1 file)

Chromium devs found a bug in the fix I wrote for bug 773903 and it was reverted upstream. I have since fixed the bug they found and the patch has landed upstream again.

I think the problem only shows up when in program with a layout like chromium (large main binary at the start of the address space) but not firefox (large library at the end), but it is probably safer to have the fixed version in m-c.

A try run is at: https://tbpl.mozilla.org/?tree=Try&rev=e01e692fae61.

I have also tested timing "./obj-x86_64-apple-darwin12.1.0/dist/bin/xpcshell -e 'quit();'" to make sure the bug 773903 has not regressed.
Attached patch upgrade itSplinter Review
Attachment #667466 - Flags: review?(ted.mielczarek)
Comment on attachment 667466 [details] [diff] [review]
upgrade it

Review of attachment 667466 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #667466 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/c63d0cd4603d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.