797377 - [Browser] Small icon shown when adding a homescreen bookmark

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Tony Chung [:tchung]]

Attachment: screenshot

Add a bookmark to the homescreen, and verify that the favicon is ultra small.  I would vote to increase the icon even if its pixelating it a bit to match the other icon sizes.

See screenshot

REpro:
1) install otoro daily build 10-1-2012 build
2) launch browser, visit a url, and add bookmark to homescreen 
3) Verify homescreen icon is mini sized.

Expected:
- favicon of site matches homescreen icon size

Actual;
- icon is small

Comment 1

[Ben Francis [:benfrancis]]

You probably get whatever icon is provided by the web site, which could be extremely small or extremely large. This is definitely a bug.

The eventual plan is to automatically generate good looking icons at the right size from favicons as per https://github.com/mozilla-b2g/gaia/issues/5453

Given that this is currently a blocking-basecamp- feature, we need a backup plan just in case it doesn't happen. Patryk suggests we scale the icons to "52x52 pixels and add the CSS drop shadow seen on the application icons".

To be clear, this is going to look pretty awful and we would prefer not to ship like this, but it is pretty easy and I suggest we fix the "bug" in this way as a stop-gap just-in-case solution. Then add the icon generation feature later if we can.

Comment 2

[Marcia Knous [:marcia]]

This happens with Apps as well - during the smoketest the other day I installed the todoist app and a very small icon appeared.

Comment 3

[Ben Francis [:benfrancis]]

In a Skype discussion Patryk suggested:

If smaller than 52x52, resize to 54x54
If larger than 54x54, resize to 52x52

I will go ahead and implement this.

Comment 4

[Ben Francis [:benfrancis]]

https://github.com/mozilla-b2g/gaia/pull/5794

Comment 5

[Ben Francis [:benfrancis]]

Actually I think what Patryk said was:

If smaller than 52x52, resize to 52x52
If larger than 54x54, resize to 54x54

which is what the patch does.

Comment 6

[Cristian Rodriguez (:crdlc)]

The code was reviewed by myself and it is correct

Comment 7

[Rebecca Billings [:rbillings]]

Verified that icons added to the homescreen are sized correctly on the 11/28 unagi build.