Fix wiki.models.Document.from_url()

RESOLVED FIXED in 2013Q1

Status

support.mozilla.org
Knowledge Base Software
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: rrosario, Assigned: berkerpeksag)

Tracking

unspecified
2013Q1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: u=dev c=wiki p=0 s=2013.3)

(Reporter)

Description

6 years ago
Currently when finding a document from the URL, we only look for a document with the locale and slug from the URL. Using the en-US slug is valid for any locale so we need to handle that case as well.

For example, "/es/kb/get-community-support" is a valid URL that gets redirected to "/es/kb/obtener-ayuda-de-la-comunidad". But passing "/es/kb/get-community-support" to Document.from_url() won't return any documents.
Ricky, could you tell me more about the significance of this?
Flags: needinfo?(rrosario)
(Reporter)

Comment 2

6 years ago
(In reply to Kadir Topal [:atopal] from comment #1)
> Ricky, could you tell me more about the significance of this?

It shouldn't have any end user impact. But we currently are logging warnings incorrectly when we find REDIRECTs that look invalid but aren't really so.
Flags: needinfo?(rrosario)
(Assignee)

Updated

6 years ago
Assignee: nobody → berker.peksag
In a pull request: https://github.com/mozilla/kitsune/pull/1140

Landed in master: https://github.com/mozilla/kitsune/commit/6233f3e591facec150363d1da83f0779ef1f8ed3

Pushed to production earlier today.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: u=dev c=wiki p=1 → u=dev c=wiki p=0 s=2013.3
Target Milestone: 2012Q4 → 2013Q1
You need to log in before you can comment on or make changes to this bug.