[socorro-crashstats] let's use a placeholder attribute instead

RESOLVED FIXED in Future

Status

Socorro
Webapp
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: peterbe, Unassigned)

Tracking

unspecified
Future
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
The little search input is using a default value as the placeholder text:

 <input type="text" id="q" name="query" value="Find Crash ID or Signature">

Joint with this awful script in nav.js:

    $("#q").focus(function () {
        $(this).attr('value', '');
    });

...which means that if you type something, then blur then focus back to change what you typed you lose what you already typed :)
(Reporter)

Comment 1

5 years ago
I know this is not urgent but I had my finger on the trigger and I was eager to see how the -moz-placeholder thing worked. 

PR: https://github.com/mozilla/socorro-crashstats/pull/113
(Reporter)

Updated

5 years ago
Depends on: 788003
Depends on: 749359
No longer depends on: 788003
(Reporter)

Updated

5 years ago
Target Milestone: --- → Future

Comment 2

5 years ago
Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/4f3d105e76fbe2504cf1288847b75e8b11c6a27f
fixes bug 797400 - placeholder for q input

https://github.com/mozilla/socorro-crashstats/commit/d3ee0742f620ef6c6426906c78c1d4eed9d19025
Merge pull request #113 from peterbe/bug797400-placeholder-for-q

bug 797400 - placeholder for q input

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.