797419 - Fix strict mode warnings in controller.js

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 1

[Mike Connor [:mconnor]]

Comment on attachment 667529 [details] [diff] [review]
Patch

moving this to mak, since he knows this code _much_ better than I do.

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 667529 [details] [diff] [review]
Patch

Review of attachment 667529 [details] [diff] [review]:
-----------------------------------------------------------------

just some styling nit in case you want to fix them (since the blame is going to change regardless), could be cleaned up better but let's avoid useless regressions :)

::: browser/components/places/content/controller.js
@@ +536,5 @@
> +
> +    var showRules = selectionAttr.split("|");
> +    var anyMatched = false;
> +    function metaDataNodeMatches(metaDataNode, rules) {
> +      for (var i=0; i < rules.length; i++) {

nit: while touching this, could you please fix the "i=0" to "i = 0"?

@@ +541,5 @@
> +        if (rules[i] in metaDataNode)
> +          return true;
> +      }
> +
> +      return false;

...and remove the newline above this return

@@ +543,5 @@
> +      }
> +
> +      return false;
> +    }
> +    for (var i = 0; i < aMetaData.length; ++i) {

... but add a newline before this for

Comment 3

[David Zbarsky (:dzbarsky)]

Pushed with nits fixed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f78565df9f0

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3f78565df9f0