move stripes-info-negative-small.png (added for bug 793338)

RESOLVED FIXED in mozilla19

Status

()

Toolkit
Themes
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: keeler, Assigned: keeler)

Tracking

unspecified
mozilla19
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

From https://bugzilla.mozilla.org/show_bug.cgi?id=793338#c12 :
> Comment on attachment 666270 [details] [diff] [review]
> patch v3
> 
> >+.center-item-box[warn="true"] {
> >+  background-image: url("chrome://mozapps/skin/extensions/stripes-info-negative-small.png");
> 
> It's unclear why you're putting this image into mozapps/skin/extensions/.
> Please file a bug on moving it away from there.

To where should this be moved? (and are we talking about moving its location in the source tree, its chrome:// location, or both?) Also, should the other, similar, files be moved? (e.g. stripes-info-positive.png, stripes-error.png, etc.)
It should be moved to browser/. stripes-info-positive.png et al are used in mozapps/skin/extensions/extensions.css, so they are in the right place.
Created attachment 669293 [details] [diff] [review]
patch
Assignee: nobody → dkeeler
Status: NEW → ASSIGNED
Attachment #669293 - Flags: review?(dao)
Comment on attachment 669293 [details] [diff] [review]
patch

Please name the file such that it's clearer what it's used for -- click-to-play-warning-stripes.png or something like this. Also please use 'hg move' instead of removing and re-adding the files.
Attachment #669293 - Flags: review?(dao) → review-
Created attachment 669624 [details] [diff] [review]
patch v2

Changed the name, used hg rename.
Attachment #669293 - Attachment is obsolete: true
Attachment #669624 - Flags: review?(dao)
Comment on attachment 669624 [details] [diff] [review]
patch v2

>diff --git a/browser/themes/gnomestripe/click-to-play-warning-stripes.png b/browser/themes/gnomestripe/click-to-play-warning-stripes.png
>new file mode 100644

Seems like the rename didn't work out here.
In toolkit/themes, it looks like gnomestripe can get things from winstripe due to some Makefile magic. In browser/themes, this doesn't seem to be the case. There never was a file in toolkit/themes/gnomestripe to move over to browser/themes/gnomestripe, so I had to add it.

Updated

6 years ago
Attachment #669624 - Flags: review?(dao) → review+
(Assignee)

Updated

6 years ago
OS: Linux → All
Hardware: x86_64 → All

Comment 8

6 years ago
https://hg.mozilla.org/mozilla-central/rev/35ec0f511f4b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.