Closed Bug 797430 Opened 7 years ago Closed 7 years ago

Cannot move separator by drag & drop

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 18

People

(Reporter: tetsuharu, Assigned: tetsuharu)

References

Details

(Keywords: regression)

Attachments

(1 file)

Enviroment:
*Firefox Nightly 18, http://hg.mozilla.org/mozilla-central/rev/635fcc11d2b1

When moving a bookmark separator by drag & drop, it cannot success to move it and occurs the following error:

Error: TypeError: dragged.uri is undefined
Source File: chrome://browser/content/places/controller.js
Line: 1434

This is regression by Bug 792968.
Attached patch patchSplinter Review
Attachment #667547 - Flags: review?(mak77)
Comment on attachment 667547 [details] [diff] [review]
patch

Review of attachment 667547 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.

Yes, the original patch there din't consider /regex/.test(undefined) is a valid check. Regardless, this version is more explicit.
Attachment #667547 - Flags: review?(mak77) → review+
Assignee: nobody → saneyuki.s.snyk
Thank you for quickly review.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/09c4dd7bf7d6
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
You need to log in before you can comment on or make changes to this bug.