797456 - Apps are getting listed in two review queues at the same time.

Status: RESOLVED WORKSFORME

(Marketplace Graveyard :: Reviewer Tools, defect, P4)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Find a free packaged app which has status = public
2. Change the app from free to paid
3. Upload a new version


observed behavior:
The packaged app is now listed under two review queues:
a) re-review
b) Updates

As per Rob, this shouldn't happen.

Comment 1

[Wil Clouser [:clouserw]]

-> rob, who is handling all the re-review triggers

Comment 2

[Andrew Williamson [:eviljeff]]

Btw, this isn't just limited to packaged apps - it happens occasionally with hosted apps now.  (I think when an app is rejected while being in the re-review queue)

Comment 3

[krupa raj[:krupa]]

The recommendation was to not allow switching between free->paid and vice versa.

cc'ing David for product confirmation.

Comment 4

[krupa raj[:krupa]]

However, right now there is no way for a developer to submit a paid app. So, at least for now we should allow free->paid option :((

Comment 5

[David Bialer [:dbialer]]

Thanks for copying here.
The double queue issue is a separate issue than the free->paid issue, though perhaps could be prevented by not allowing this switch.

The first issue: I think the proper behavior on a switching would be that it would go in the update queue, unless something else triggered a reason to re-review (I am not an expert on our re-review trigger policies though).

The banning of switching free to paid was suggested by Krupa to prevent gaming the popularity system - building up an audience with free, then switching the app to paid.  There may be other issues involved with updates/reinstalls after an app is switched (because there is no receipt stored on the device).

If we ban free to paid conversions, then we would need some guidance into how this could be accomplished:
A way to avoid this is either by guiding developers into having a $0 app (which I understand is different than free) in that a receipt is generated.  This may not prevent gaming the system, but could be used by developers as a promotion.  

Another way may be to just guide developers into resubmitting an app as a new app when moving from free to paid.

Of course the first issue could go away if we just ban converting to paid apps, but
I am interested in other peoples' thought on best practices.

Comment 6

[Andrew Williamson [:eviljeff]]

For the double queue issue: if its as easy as tweaking a few queries to not show pending or updates apps in the re-review queue then I agree it should be done.  Its a fairly trivial issue imo so if its a lot of work then wontfix.

Either this issue or the free>paid issue should be split into a different bug.

Comment 7

[Andrew Williamson [:eviljeff]]

For the double queue issue: if its as easy as tweaking a few queries to not show pending or updates apps in the re-review queue then I agree it should be done.  Its a fairly trivial issue imo so if its a lot of work then wontfix.

Either this issue or the free>paid issue should be split into a different bug.

Comment 8

[Andrew Williamson [:eviljeff]]

Looks like we now handle the example Krupa gave in comment #0

https://github.com/mozilla/zamboni/blob/master/mkt/developers/forms_payments.py#L387-L400

so marking as worksforme.  

Whether this it should be allowed at all is a separate issue that we can log a new bug to address if Product make a decision to disallow.