797792 - [Clock] If next alarm comes more than 24 HOURS, it should display in DAYS instead of HOURS in countdown indicator

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[John Shih]

## Environment :
Otoro phone, build 2012-10-03
* "gaia" revision= a3339652136fde9e5207e1bc1263a410c84f55fc 
* "releases-mozilla-central" revision= aecce9686d0b0e6ec25bb31e837eadace251a951
  
## Repro :
1. launch clock app
2. press "+" button to alarm add page
3. Set Repeat to today
4. Set the alarm time same as the time display on status bar (e.g. now is 03:24, set alarm time 03:24)
5. Press "Done" 

## Expected :
1. See the countdown indicator show "The alarm is set for 7 DAYS from now"

## Actual :
1. The countdown indicator shows "The alarm is set for 167 HOURS 59 MINUTES form now" which doesn't make sense that much

Comment 1

[[e-mail], [e-mail]]

Hi John,
I don't see the remained days display in our spec. of Clock APP.
But, I agree we could have the good experience for user after UX's confirmation.
If we want to have the feature, we also need to refine the localization.
Because of Josh is on PTO, I assign the issue to Casey.

Hi Casey,
Do we need to have the remained days display in the banner?
Please confirm the behavior and re-assign the issue to me.
Thank you.

Comment 2

[Josh Carpenter [:jcarpenter]]

Hi guys, good catch. We would prefer to convert "hours + minutes" to "days + hours" if the time span exceeds 24 hours. This is a v1 nice-to-have, but not a blocker.

Comment 3

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

I've made a patch for this: https://github.com/mozilla-b2g/gaia/pull/7750

Comment 4

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Link to the pull request patch at Github

Comment 5

[[e-mail], [e-mail]]

Hi Sergi,
I left some message on your pull request. You should update your patch again since it has some conflict. 

Then, please set reviewer to me. I think your patch works for me. Nice job. Thanks for your help.

Comment 6

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Hi Ian,

I have updated the patch. As for assigning it to you, I don't think I have rights for that. In 'Assigned to' it is already assigned to you, though.

Comment 7

[Hernán Rodriguez Colmeiro (:peregrino)]

Comment on attachment 707630 [details] [review]
Link to the pull request patch at Github

Setting 'review?' to :ianliu as sergim doesn't have enough privileges

Comment 8

[[e-mail], [e-mail]]

Since Sergi handle the issue, I assign the issue to him.

Comment 9

[[e-mail], [e-mail]]

Comment on attachment 707630 [details] [review]
Link to the pull request patch at Github

It works for me. r=me

Comment 10

[[e-mail], [e-mail]]

Sergi,
Could you please squash your pull request? Then, I'll help to merge it. Thanks:)

Comment 11

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Done. The new pull request is at https://github.com/mozilla-b2g/gaia/pull/7958. It should be ready to merge.

(In reply to Ian Liu [:ianliu] from comment #10)
> Sergi,
> Could you please squash your pull request? Then, I'll help to merge it.
> Thanks:)

Comment 12

[[e-mail], [e-mail]]

Since the pr(https://github.com/mozilla-b2g/gaia/pull/7958) is merged, you can close the issue. Thank you.

Comment 13

[Askeing Yen[:askeing][:fyen]]

Device unagi
gaia   122ee16093d9730de7a9c6beba989adeb5d716ae
gecko  95bf443385bbd8ee611be1586ec975e609acd006

Verified.