797842 - [contacts] Unit tests are broken since search refactor

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P2)

Description

[Francisco Jordano [:arcturus] [:francisco]]

Right now the unit tests for the contacts app are broken since we moved the search to a separate js to be reused.

We will need to fix and mock the new component and move the tests to check it properly.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Was already solved in other commits.

Unit tests already working

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Reopening since unit tests are broken and are an important check before accepting new checkings in the current state of the project

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to GitHub PR 7712

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Adding tef? flag cause this change is not risky and will be needed to land any bug in a safe way for contacts.

Also adding the tracking-b2g18 to take into account this for v1

Comment 5

[Alex Keybl [:akeybl]]

Please land on master in preparation for uplift to v1-train.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Landed

https://github.com/mozilla-b2g/gaia/commit/4b42b089bf9e3fbc841062ceb61fac742f4aec3b

Comment 7

[Daniel Coloma:dcoloma]

This is a safe change, with zero regression risk that furthermore helps preventing further regressions. We decided because of that to make it tracking-b2g18+. Why has it been marked as 19+?

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Sorry, forgot to mark as fixed.

This is already in master, ready for the uplift.

Cheers!

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 704617 [details]
Pointer to GitHub PR 7712

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): regression, not updating the unit test while updating the app
User impact if declined: none
Testing completed: yes
Risk to taking this patch (and alternatives if risky): 0, this is just unit test

Asking for uplift as they are just unit  test and will help us to detect possible errors in future changes

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 704617 [details]
Pointer to GitHub PR 7712

Approving for v1-train since this is test only.

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: f85c6d83f1313cdd0ebfb2941c6bbdcb3e9c329d

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Batch edit: Bugs fixed on b2g18 after 1/25 merge to v1.0 branch are fixed on v1.0.1 branch.