Closed Bug 797883 Opened 9 years ago Closed 9 years ago

Create Bugzilla->process_cache

Categories

(Bugzilla :: Bugzilla-General, enhancement)

Product:
Bugzilla
Component:
Bugzilla-General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 4.4

People

(Reporter: glob, Assigned: glob)

Details

(Keywords: perf)

Attachments

(1 file, 1 obsolete file)

patch v1
2.36 KB, patch
LpSolit
: review+
Details | Diff | Splinter Review 
similar to Bugzilla->request_cache, we need a process_cache which will cache items for the lifetime of the process.  for mod_cgi, this is identical to the request_cache, however for mod_perl this would live until the worker process is terminated.
Severity: normal → enhancement
OS: Mac OS X → All
Hardware: x86 → All
Attached patch patch v1 (obsolete) — — Splinter Review
Attachment #668010 - Flags: review?(LpSolit)
Attached patch patch v1 — — Splinter Review 
forgot to remove $_localconfig.
Attachment #668010 - Attachment is obsolete: true
Attachment #668010 - Flags: review?(LpSolit)
Attachment #668013 - Flags: review?(LpSolit)
Comment on attachment 668013 [details] [diff] [review]
patch v1

>=== modified file 'Bugzilla/Template.pm'

>+    Bugzilla->process_cache->{shared_providers} ||= {};
>+
>+    my $shared_providers = Bugzilla->process_cache->{shared_providers};


This looks good, but please merge both lines:

    my $shared_providers = Bugzilla->process_cache->{shared_providers} ||= {};


r=LpSolit
Attachment #668013 - Flags: review?(LpSolit) → review+
Let's take it for 4.4 too. I don't want to rewrite my patch for bug 795650 twice.
Status: NEW → ASSIGNED
Flags: approval4.4+
Flags: approval+
Target Milestone: --- → Bugzilla 4.4
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla.pm
modified Bugzilla/Template.pm
Committed revision 8413.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla.pm
modified Bugzilla/Template.pm
Committed revision 8408.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Added to relnotes for 4.4.
You need to log in before you can comment on or make changes to this bug.