797984 - The *_lang_files tags for setting lang files in a template don't work quite right

Status: RESOLVED FIXED

(www.mozilla.org :: Bedrock, defect, P4)

Description

[Paul [:pmac] McLanahan]

In doing some testing on Bug #783202 I found that the `{% add_lang_files %}` and `{% set_lang_files %}` tags don't work as advertised. The lang files set at the end are supposed to contain the ones for the rendered file, any ones in parent templates, and the defaults, in that order. The inheritance is not working at all.

Also they only work from within blocks, but most of the use of these tags in our templates is from outside of blocks.

This requires more testing and possibly a rework of how these are built.

Some initial tests have been added in `lib/l10n_utils/tests/test_template.py`.

Comment 1

[Mike Alexis [:malexis]]

Does this impact the l10n work needed for MWC?

Comment 2

[Paul [:pmac] McLanahan]

I don't believe so. We've been fine so far with the way it is and I believe we can continue on for the foreseeable future. It's just not the way it "should" be, but it's not a high priority.

Comment 3

[Paul [:pmac] McLanahan]

I think :jbertsch meant to make it a P4 priority.

Comment 4

[Paul [:pmac] McLanahan]

Fixed because we've removed lang file support from the site.