797997 - Sync setup activities still not using system theme

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Android Sync, defect, P4)

Description

[Aaron Train [:aaronmt]]

Attachment: Nexus 7 (Android 4.1.1) - Screenshot (Nightly 10/04)

Perhaps they need a fix similar to bug 773293.

See screenshot; Nexus 7 with Gingerbread buttons.

Comment 1

[Nick Alexander :nalexander [he/him]]

We intentionally moved Android Sync to use whatever theme Fennec uses, in order that Set up Sync from Fennec would look consistent.  Could you verify that Fennec's theming (for example, prefs, buttons, etc) and Android Sync's differ?  If they do, we'll move on this.  Thanks!

Comment 2

[Aaron Train [:aaronmt]]

The dialog on the left in the screenshot is 'Clear Private Data' in Fennec's Settings.

Comment 3

[Nick Alexander :nalexander [he/him]]

(In reply to Aaron Train [:aaronmt] from comment #2)
> The dialog on the left in the screenshot is 'Clear Private Data' in Fennec's
> Settings.

Sorry, I looked at the screen shot and totally missed that it was Fennec on the left.  Thanks for the report!

Comment 4

[Nick Alexander :nalexander [he/him]]

Okay, initial research complete.  Short story: Android theming is truly awful.  Long story: it is possible to do this, sort of.  In no way is the theme shown in the screenshot the "system theme".  It is, in fact, a custom AlertDialog theme.  Huge segments of the internet are trying to copy this theme, and it's rather difficult to make it look good.  In fact, I wager that making it look good and work well on all Android versions is not possible.

I'm pretty convinced that this is not worth addressing.  sriram, if you have suggestions, please let me know.  I am on board with improving our buttons somewhat, possibly with ibarlow's input.

Comment 5

[Sriram Ramasubramanian [:sriram]]

That! is super hard to do!
We actually wanted a similar theme for DoorHangers, but default ButtonBar style didn't help us.

Comment 6

[Nick Alexander :nalexander [he/him]]

(In reply to Sriram Ramasubramanian [:sriram] from comment #5)
> That! is super hard to do!
> We actually wanted a similar theme for DoorHangers, but default ButtonBar
> style didn't help us.

Thanks for confirmation -- that's what I was looking at too.  I'm going to make this low priority, and consider making Android Sync buttons follow Fennec's DoorHanger buttons.  That is, unless ibarlow has input.

Comment 7

[Aaron Train [:aaronmt]]

It's using it now but there are other theming issues such as bug 850946.