devicemanagerSUT should only print a failed connection in _sendCmds if debug is higher or it can't reconnect

RESOLVED FIXED

Status

Testing
Mozbase
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
So in _sendCmds if we fail to reconnect to the SUT socket, we output a "Remote Device Error" so far, instead we should only do that if debug >= 4.
(Assignee)

Comment 1

6 years ago
Created attachment 668160 [details] [diff] [review]
[git-mozdevice] Do eeet

This change is necessary, and already reflected in the patch adding it to build-tools/sut_tools
Attachment #668160 - Flags: review?(jmaher)
Comment on attachment 668160 [details] [diff] [review]
[git-mozdevice] Do eeet

Review of attachment 668160 [details] [diff] [review]:
-----------------------------------------------------------------

I have added this to my sut patch, but this doesn't get upstreamed, this patch gets us upstreamed!
Attachment #668160 - Flags: review?(jmaher) → review+
(Assignee)

Comment 3

6 years ago
...now just need someone to push this to github for me :-)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.