798131 - [settings] when connected to wifi, the "connected to {network}" label on the main screen needs capitalization

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Dietrich Ayala (:dietrich)]

should be "Connected".

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

If that's the case shouldn't they all be capitalized?

https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/locales/settings.en-US.properties

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Line 33 to 43

Comment 3

[:Margaret Leibovic]

We should get UX people to tell us what they want here.

(Does the uiwanted keyword get the attention of B2G UX people? Is there someone in particular who I should cc?)

Comment 4

[Fabien Cazenave [:kaze]]

Josh, would you mind doing a capitalization review on Settings, like you did with other apps before?

Comment 5

[Josh Carpenter [:jcarpenter]]

This will come with the string freeze audit, but briefly, our policy is:

Prompts titles

* Sentence case
* Limit to one line
* Forego ending punctuation unless title is a question
* Try to frontload core of message into the first few words


Buttons

* Title case
* One or two words
* Use verbs that precisely describe the button's action, such as "Cancel", "Clear History", "Add Email", "Select All", etc

For subheadings like we see in Settings, our policy is to use sentence case. 

Under no circumstances should we have all-caps buttons. I see a few of those in current Settings implementation.

Comment 6

[Fabien Cazenave [:kaze]]

(In reply to Josh Carpenter [:jcarpenter] from comment #5)
> Under no circumstances should we have all-caps buttons. I see a few of those
> in current Settings implementation.

I completely agree with that, but that’s how labels have been defined in the building blocks: https://wiki.mozilla.org/Gaia/Design/BuildingBlocks#Buttons

I proposed to remove this “uppercase” rule from the `buttons.css' block but it’s been refused, so I’ve overwritten this CSS rule in a recent commit (not landed yet).

Long story short, this all-caps issue should be “fixed” for the Settings app but the problem might appear in other apps once they start using the building block.

Comment 7

[Fabien Cazenave [:kaze]]

(In reply to Josh Carpenter [:jcarpenter] from comment #5)
> For subheadings like we see in Settings, our policy is to use sentence case. 

OK, I’ll write a patch for that. Thanks!

Comment 8

[Fabien Cazenave [:kaze]]

This has been fixed by Staś along with bug 812977:
https://github.com/mozilla-b2g/gaia/commit/f6aa5f0#L15L31