798198 - social sidebar should be hidden when toolbar is not visible.

Status: RESOLVED WONTFIX

(Firefox Graveyard :: SocialAPI, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

eg, on about:addons, the toolbar is hidden, so there are no ambient toolbar notifications shown for the social feature, but the social sidebar remains visible.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

For reference, this will probably involve adding a tab switch event handler and calling hideChromeForLocation (http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#4169)

Also, this will probably require the ability to have different sidebar states per browser window, so blocked by bug 798201

Comment 2

[Asa Dotzler [:asa]]

I don't feel strongly that we have to fix this. If a patch is easy, let's get it but if not, this can definitely wait.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Rough WIP patch

This patch is close, but I think the event listener isn't entirely correct since it doesn't handle switching tabs, only changing the location of the current tab.

Comment 4

[Shane Caraveo (:mixedpuppy)]

bug 935640 made the social sidebar work like and look more like other existing sidebars.  All other sidebars do not become hidden in the situation described in this bug.  Should the social sidebar be different in that respect alone?

Comment 5

[Shane Caraveo (:mixedpuppy)]

Actually, Australis no longer hides the toolbar in about:addons/etc. as well, so this is WONTFIX.