Closed
Bug 798205
Opened 9 years ago
Closed 9 years ago
move ia2 files under ia2 directory
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: surkov, Assigned: surkov)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
65.12 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #668314 -
Flags: review?(trev.saunders)
Comment 1•9 years ago
|
||
Comment on attachment 668314 [details] [diff] [review] patch >+SHARED_LIBRARY_LIBS += ../src/windows/ia2/$(LIB_PREFIX)accessibility_toolkit_ia2_s.$(LIB_SUFFIX) > SHARED_LIBRARY_LIBS += ../src/windows/uia/$(LIB_PREFIX)accessibility_toolkit_uia_s.$(LIB_SUFFIX) I thought you needed to end the first line with a \ ? >+MODULE = accessibility >+LIBRARY_NAME = accessibility_toolkit_ia2_s >+EXPORT_LIBRARY = .. >+LIBXUL_LIBRARY = 1 nit, =1 >+ia2AccessibleValue::QueryInterface(REFIID iid, void** ppv) > { > *ppv = NULL; > > if (IID_IAccessibleValue == iid) { >- nsCOMPtr<nsIAccessibleValue> valueAcc(do_QueryObject(this)); >- if (!valueAcc) >- return E_NOINTERFACE; >+ AccessibleWrap* valueAcc = static_cast<AccessibleWrap*>(this); >+ if (valueAcc->HasNumericValue()) { >+ *ppv = static_cast<IAccessibleValue*>(this); >+ (reinterpret_cast<IUnknown*>(*ppv))->AddRef(); why not just AddRef() ? >rename from accessible/src/msaa/CAccessibleValue.h >rename to accessible/src/windows/ia2/ia2AccessibleValue.h >--- a/accessible/src/msaa/CAccessibleValue.h >+++ b/accessible/src/windows/ia2/ia2AccessibleValue.h >@@ -7,17 +7,17 @@ > > #ifndef _ACCESSIBLE_VALUE_H > #define _ACCESSIBLE_VALUE_H > > #include "nsISupports.h" why? if you like you could convert some of the --try goo to the A11Y_ macros or you could file a gfb to do it
Attachment #668314 -
Flags: review?(trev.saunders) → review+
Assignee | ||
Comment 2•9 years ago
|
||
(In reply to Trevor Saunders (:tbsaunde) from comment #1) > Comment on attachment 668314 [details] [diff] [review] > patch > > >+SHARED_LIBRARY_LIBS += ../src/windows/ia2/$(LIB_PREFIX)accessibility_toolkit_ia2_s.$(LIB_SUFFIX) > > SHARED_LIBRARY_LIBS += ../src/windows/uia/$(LIB_PREFIX)accessibility_toolkit_uia_s.$(LIB_SUFFIX) > > I thought you needed to end the first line with a \ ? ok > >+MODULE = accessibility > >+LIBRARY_NAME = accessibility_toolkit_ia2_s > >+EXPORT_LIBRARY = .. > >+LIBXUL_LIBRARY = 1 > > nit, =1 no spaces? why? it was copy/paste I think. > > >+ia2AccessibleValue::QueryInterface(REFIID iid, void** ppv) > > { > > *ppv = NULL; > > > > if (IID_IAccessibleValue == iid) { > >- nsCOMPtr<nsIAccessibleValue> valueAcc(do_QueryObject(this)); > >- if (!valueAcc) > >- return E_NOINTERFACE; > >+ AccessibleWrap* valueAcc = static_cast<AccessibleWrap*>(this); > >+ if (valueAcc->HasNumericValue()) { > >+ *ppv = static_cast<IAccessibleValue*>(this); > >+ (reinterpret_cast<IUnknown*>(*ppv))->AddRef(); > > why not just AddRef() ? ok > > >rename from accessible/src/msaa/CAccessibleValue.h > >rename to accessible/src/windows/ia2/ia2AccessibleValue.h > >--- a/accessible/src/msaa/CAccessibleValue.h > >+++ b/accessible/src/windows/ia2/ia2AccessibleValue.h > >@@ -7,17 +7,17 @@ > > > > #ifndef _ACCESSIBLE_VALUE_H > > #define _ACCESSIBLE_VALUE_H > > > > #include "nsISupports.h" > > why? artifact > if you like you could convert some of the --try goo to the A11Y_ macros or > you could file a gfb to do it gfb should be good
Comment 3•9 years ago
|
||
> > >+LIBRARY_NAME = accessibility_toolkit_ia2_s
> > >+EXPORT_LIBRARY = ..
> > >+LIBXUL_LIBRARY = 1
> >
> > nit, =1
>
> no spaces? why? it was copy/paste I think.
I just meant 1 instead of ..
Assignee | ||
Comment 4•9 years ago
|
||
ok, I thought it's a path
Assignee | ||
Comment 5•9 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/e8f535c751d1
Target Milestone: --- → mozilla18
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e8f535c751d1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•