79827 - javascript error in messengercompose.xul

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P4)

Description

[Henrik Gemal]

just got this in my console:

JavaScript error:
 line 0: EditorInitEditMenu is not defined

/mailnews/compose/resources/content/messengercompose.xul, line 266 -- <menupopup
oncreate="EditorInitEditMenu()">

build 20010509

Comment 1

[Jean-Francois Ducarroz]

--> varada

Comment 2

[Håkan Waara]

Taking. I eventually saw this too. Fix coming up, varada please review.

Comment 3

[Håkan Waara]

Attachment: fix. EditorInitEditMenu() or anything similar to that didn't exist, so I got rid of it.

Comment 4

[varada]

The code in editor.js was changed just yesterday and I dont think the solution
is to get rid of the function. I saw that it was replaced by the InitPastAsMenu.
cmanske is probably the right person to ask if this is the function that should
be used now or if we can just get rid of the existing one with no consequences.

Comment 5

[Håkan Waara]

Cmanske, 

Varada thinks you are the person to ask about the deal with removing
"EditorInitEditMenu()" but not all of its callers (like, messengercompose.xul).

Is it renamed or removed or what?

Comment 6

[Charles Manske]

My bad. Sorry! r=cmanske on fix. We don't need it since it didn't do anything!

Comment 7

[David :Bienvenu]

sr=bienvenu

Comment 8

[Håkan Waara]

fix checked in.

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

Verified with a debug build (pulled at noon today; 5-14-2001).
user_pref("javascript.options.strict", true); // enables strict javascript
warnings didn't show this warning when using HTML msg compose (which uses editor).