798286 - [Email] [VD implementation] "No mail messages" should have the correct design

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Victoria Gerchinhoren [:vicky]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0) Gecko/20100101 Firefox/4.0
Build ID: 20110318052756



Actual results:

The empty messages screen has a balck bold text in the middle.


Expected results:

Should have the watermark image, a light grey text, a line above it...
See: https://www.dropbox.com/sh/gn7qomol29ezppj/h3oHj8AjhG#/

Comment 1

[Steve Chung [:steveck]]

Hi Patryk, we need the watermark for this issue, could you please provide the background image?
Thanks.

Comment 2

[Patryk Adamczyk [:patryk] UX]

Attachment: optimized mail watermark

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Wrong Andrew Sutherland; I suggest using ":asuth" for the auto-complete to get me.  In any event, Steve Chung is handling this, assigning.

Comment 4

[Steve Chung [:steveck]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/5762

Comment 5

[Dominic Kuo [:dkuo]]

Comment on attachment 670276 [details]
https://github.com/mozilla-b2g/gaia/pull/5762

r+, and please see https://github.com/mozilla-b2g/gaia/pull/5762#issuecomment-9475711

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 670276 [details]
https://github.com/mozilla-b2g/gaia/pull/5762

dkuo/schung, please request approval to land the patches like this one by using the approval-gaia-master flag on the attachment and convey the changes are substantially visual changes and that the reviewer has smoke-tested, which I assume is the case.

Comment 7

[Steve Chung [:steveck]]

Comment on attachment 670276 [details]
https://github.com/mozilla-b2g/gaia/pull/5762

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 9

[Andrew Sutherland [:asuth] (he/him)]

I smoke-tested and landed this on https://github.com/mozilla-b2g/gaia/pull/6213
Landed on gaia/master with merge:
https://github.com/mozilla-b2g/gaia/commit/90d6f5c7b0177b9b77e2573e3e52d024c1f449f7

Thanks Steve!

Comment 10

[Mila Davydova]

Verified with Unagi, build ID 20120102070202
The empty messages screen has the watermark image, a light grey text "No mail in this Folder" and  a line above it.