Closed Bug 798355 Opened 10 years ago Closed 10 years ago

Unneeded base class conversion operator in MachMsgPortDescriptor

Categories

(Core :: IPC, defect)

Product:
Core
Component:
IPC
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla18

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

Attachments

(1 file)

Patch (v1)
616 bytes, patch
cjones
: review+
Details | Diff | Splinter Review 
In file included from /Users/ehsanakhgari/moz/mozilla-central/ipc/glue/GeckoChildProcessHost.cpp:15:
/Users/ehsanakhgari/moz/mozilla-central/ipc/chromium/src/chrome/common/mach_ipc_mac.h:116:3: warning: conversion function converting 'MachMsgPortDescriptor' to its base class
      'mach_msg_port_descriptor_t' will never be used
  operator mach_msg_port_descriptor_t&() {
  ^

(One of the smartest warnings in clang!)
Attached patch Patch (v1) — — Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #668440 - Flags: review?(jones.chris.g)
Attachment #668440 - Flags: review?(jones.chris.g) → review+
https://hg.mozilla.org/mozilla-central/rev/747ca210aaa0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.