Closed
Bug 798476
Opened 9 years ago
Closed 9 years ago
Fallback to --with-system-libevent=/usr when system libevent doesn't have a pkgconfig file
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla18
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
1.46 KB,
patch
|
ted
:
review+
jbeich
:
feedback-
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #668520 -
Flags: review?(ted.mielczarek)
Comment 2•9 years ago
|
||
Comment on attachment 668520 [details] [diff] [review] Fallback to --with-system-libevent=/usr when system libevent doesn't have a pkgconfig file Review of attachment 668520 [details] [diff] [review]: ----------------------------------------------------------------- ::: configure.in @@ +3941,5 @@ > +if test "$LIBEVENT_DIR" = yes; then > + PKG_CHECK_MODULES(MOZ_LIBEVENT, libevent, > + MOZ_NATIVE_LIBEVENT=1, > + LIBEVENT_DIR=/usr) > +fi Is libevent always going to be available in /usr? If not we should preserve the error here.
Attachment #668520 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Ted Mielczarek [:ted] from comment #2) > Is libevent always going to be available in /usr? If not we should preserve > the error here. The point is to fallback to the code path that checks libevent is actually there. So if it is not, you hit the error from there.
Comment on attachment 668520 [details] [diff] [review] Fallback to --with-system-libevent=/usr when system libevent doesn't have a pkgconfig file `else' should probably be replaced by elif test -z "$MOZ_NATIVE_LIBEVENT"; then $ pkg info -xo event libevent2-2.0.19: devel/libevent2 $ ./configure --with-system-libevent ... checking for libevent... yes checking MOZ_LIBEVENT_CFLAGS... -I/usr/local/include/event2/compat -I/usr/local/include checking MOZ_LIBEVENT_LIBS... -L/usr/local/lib/event2 -levent-2.0 checking for event.h... no configure: error: --with-system-libevent requested but event.h not found Exit 1
Attachment #668520 -
Flags: feedback-
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b3d773f582f
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1b3d773f582f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Updated•3 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•