798476 - Fallback to --with-system-libevent=/usr when system libevent doesn't have a pkgconfig file

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Fallback to --with-system-libevent=/usr when system libevent doesn't have a pkgconfig file

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 668520 [details] [diff] [review]
Fallback to --with-system-libevent=/usr when system libevent doesn't have a pkgconfig file

Review of attachment 668520 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +3941,5 @@
> +if test "$LIBEVENT_DIR" = yes; then
> +    PKG_CHECK_MODULES(MOZ_LIBEVENT, libevent,
> +        MOZ_NATIVE_LIBEVENT=1,
> +        LIBEVENT_DIR=/usr)
> +fi

Is libevent always going to be available in /usr? If not we should preserve the error here.

Comment 3

[Mike Hommey [:glandium]]

(In reply to Ted Mielczarek [:ted] from comment #2)
> Is libevent always going to be available in /usr? If not we should preserve
> the error here.

The point is to fallback to the code path that checks libevent is actually there. So if it is not, you hit the error from there.

Comment 4

[Jan Beich]

Comment on attachment 668520 [details] [diff] [review]
Fallback to --with-system-libevent=/usr when system libevent doesn't have a pkgconfig file

`else' should probably be replaced by elif test -z "$MOZ_NATIVE_LIBEVENT"; then

$ pkg info -xo event
libevent2-2.0.19: devel/libevent2

$ ./configure --with-system-libevent
...
checking for libevent... yes
checking MOZ_LIBEVENT_CFLAGS... -I/usr/local/include/event2/compat -I/usr/local/include
checking MOZ_LIBEVENT_LIBS... -L/usr/local/lib/event2 -levent-2.0
checking for event.h... no
configure: error: --with-system-libevent requested but event.h not found
Exit 1

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b3d773f582f

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1b3d773f582f