79858 - ident sometimes gives wrong line numbers for definitions in .java files

Status: RESOLVED FIXED

(Webtools Graveyard :: MXR, defect)

Description

[Eric Agnew]

I just installed LXR locally and found the same problem- so far I've only found
it to occur in .java files.

Example: http://lxr.mozilla.org/mozilla/ident?i=ISPDynamicData
This (currently) says that the identifier is defined as a class on line 9 and as
 function on line 29- the 'Referenced in' matches list lines 31 and 51. 
Checking the file reveals that lines 31 and 51 are the only (non-comment) lines
on which it appears.

It appears that it is simply not counting the first two sets of comments in this
case, but I've also found cases where the line number listed is actually -after-
the line number on which the identifier appears, which means it's somehow
counting non-existant lines somewhere along the way.  I've poked around the
genxref file for a bit, but I can't seem to find where this is happening...

Comment 1

[Eric Agnew]

Attachment: patch to fix line-numbering issues

Comment 2

[Eric Agnew]

Patch submitted- the first two blocks make sure that the java_clean subroutine
doesn't remove newlines when clearing out 'import' and 'package' lines, and the
3rd block preserves them in certain patterns of function definitions, thus
preventing the newline from being stripped from:

----
public Class ()
{
----
Unfortunately, I'm STILL getting some cases where the line numbers don't match
up.  grr.

Comment 3

[Dave Miller [:justdave]]

reassigning endico's bugs to default owner

Comment 4

[Chase Phillips]

Mass reassign of open bugs for [e-mail] to [e-mail].

Comment 5

[J. Paul Reed [:preed]]

Reassigning all LXR bugs assigned to [e-mail] to the default LXR owner (sorry Bear!)

We aren't actively working on these (if that's wrong, please reassign to yourself/a real person). 

Comment 6

[Reed Loden [:reed]]

Do we need this patch anymore, or has the bug been fixed?

Comment 7

[timeless]

changeset 37a2794b3244

thanks and very sorry for the delay.