798614 - Don't keep opening and closing the word suggestion area when switching to alternate characters

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

For numeric keyboards, we should never open the word suggestion bar.

For alphanumeric entry, word suggestion stays open while I enter alphabetical characters, but when I switch to alternate characters (numeric et al.) it closes.  Then when I switch back it opens again.

This is pretty janky.  How about we just clear the suggestions if a non-alpha character is entered?

Also, we're showing word suggestions for the URL input type.  That's a bug, right?  (The awesomebar does this job.)

Comment 1

[David Flanagan [:djf]]

Thanks for filing this, Chris. 

I just fixed a similar bug for opening and closing the suggestion panel after each word.  It should be easy to fix this for switching to alternate characters.

Word suggestions for URL input is a bug, I can't reproduce it: I don't see word suggestions when I enter a URL in the browser app. Are you seeing them in web content with input type="url" or in an app?

#796544 (support the inputmode attribute) will help with this a lot, too.

I'm assigning this to myself and adding it to my keyboard meta bug.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(In reply to David Flanagan [:djf] from comment #1)
> Word suggestions for URL input is a bug, I can't reproduce it: I don't see
> word suggestions when I enter a URL in the browser app. Are you seeing them
> in web content with input type="url" or in an app?
> 

I meant the suggestion UI coming up *at all*.

Comment 3

[David Flanagan [:djf]]

Chris, 

I just flashed the latest nightly, and now I see what you mean.  That's a horrible regression. Yuck.  DavidS has already filed a bug about it: #797406.  

Let's move all big gray bar stuff to that bug, and keep this one focused on not being janky when going in and out of number mode.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

CCing Rudy and Casey.

I would personally love to not showing an empty UI (screen real estate are precious!) but if that cause performance problem, we have no choice :'(

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

It's not the performance I'm concerned about.  It's the jank of opening and closing the suggestions panel as I switch back and forth from the page of alpha characters to alternate characters.

Have you tried it?

Comment 6

[David Flanagan [:djf]]

Chris,

Tim has seen the big gray bar, but thought it was intentional, so he was commenting here to say that he'd like the big gray bar to go away sometimes :-)

I think we're all on the same page here.

Comment 7

[David Flanagan [:djf]]

Fixed by https://github.com/mozilla-b2g/gaia/pull/6007