798686 - PLC causes false positives in signaling unittests

Status: NEW

(Core :: WebRTC: Signaling, defect, P4)

Description

[Ethan Hugg [:ehugg]]

The packet loss concealment seems to be active even if there is no connection.  This can cause the audio to appear to be sending/receiving when it really is not.  We need some limit to PLC so that errors in connectivity can be properly discovered in unittests.

For example, we had the SDP_MAX_LINE_LEN causing a truncation of the SHA-256 fingerprint, but the signaling_unittests still returned success because the PLC was hiding the error.

Comment 1

[Nils Ohlmeier [:drno]]

Also all the test_peerConnection_* mochitests in dom/media/tests/mochitest are affected by this.

And also test_peerConnection_basicVideo.html reports a working video stream, even if no video packets are received. Not sure if or why PLC would do that for video.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

PLC only applies to audio, so that's not the reason

Comment 3

[Bulk Bug Changes for mreavy's org]

Mass change P3->P4 to align with new Mozilla triage process.