Send Unsent Messages should be disabled when offline.

VERIFIED FIXED in mozilla0.9.4

Status

SeaMonkey
MailNews: Backend
P2
normal
VERIFIED FIXED
17 years ago
14 years ago

People

(Reporter: laurel, Assigned: Mohan Bhamidipati)

Tracking

Trunk
mozilla0.9.4

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed by 79865, verified on trunk)

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
Using may09 commercial build

When in offline state, File|Send Unsent Messages should be disabled (4.x does 
this) as it does nothing.
(Reporter)

Updated

17 years ago
QA Contact: esther → gchan

Comment 1

17 years ago
Reassign to Mohanb

Comment 2

17 years ago
Agree.

Comment 3

17 years ago
-> Mohanb
Assignee: dianesun → mohanb

Comment 4

17 years ago
In 4.x for Mac, if you are offline when you choose `Send Unsent Messages', 
Mozilla just goes online and sends the messages. I think this is preferable to 
disabling the menu item. (But then I'm biased, because I use this feature 
regularly.)

Comment 5

17 years ago
in windows you are usually asked ~do you want to go online?~ ...

Comment 6

17 years ago
mpt and timeless bring up a good point. When the user clicks "Get Msg" and they 
are offline, we prompt them "You are currently offline. Would you like to go 
online and get your new messages?".  

It would be nice to do the same thing for sending messages. "You are currently 
offline. Would you like to go online and send your unsent messages?"
(Assignee)

Updated

17 years ago
Priority: -- → P2
Target Milestone: --- → mozilla0.9.2
(Assignee)

Comment 7

17 years ago
Created attachment 38132 [details] [diff] [review]
proposed patch (note : mailWindowOverlay.js has both segments a) for send unsent messages b) for get new messages)

Comment 8

17 years ago
PDT+ per 6/12 mtg.
Whiteboard: [PDT+]
(Assignee)

Updated

17 years ago
Whiteboard: [PDT+] → [PDT+] requesting r & sr
(Assignee)

Comment 9

17 years ago
cc'ing bhuvan for review & sspitzer for super review;

Comment 10

17 years ago
This is very similar to 79865. Please try to rework this one too. You can add 
error/alert/confirm messages in .properties file and then use them in .confirm() 
calls.

Also, please post the screenshots.

bhuvan

(Assignee)

Updated

17 years ago
Whiteboard: [PDT+] requesting r & sr → [PDT+] requesting r & sr Planning for checkin by FRI : 06/22
(Assignee)

Comment 11

17 years ago
bug # 79865 has the combined patch;
(Assignee)

Updated

17 years ago
Whiteboard: [PDT+] requesting r & sr Planning for checkin by FRI : 06/22 → [PDT+]

Updated

17 years ago
Whiteboard: [PDT+] → [PDT+] patch in progress
(Assignee)

Updated

17 years ago
Whiteboard: [PDT+] patch in progress → [PDT+] fixed by 79865
(Assignee)

Updated

17 years ago
Blocks: 79480

Comment 12

17 years ago
pushing out. 0.9.2 is done. (querying for this string will get you the list of
the 0.9.2 bugs I moved to 0.9.3)
Target Milestone: mozilla0.9.2 → mozilla0.9.3

Comment 13

17 years ago
Removing PDT+, marking nsbranch; should be checked into the 0.9.3 trunk ASAP,
tested & verified, then submitted for limbo builds.
Keywords: nsBranch
Whiteboard: [PDT+] fixed by 79865 → fixed by 79865

Comment 14

17 years ago
Fix checked in on behalf on mohanb.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 15

17 years ago
Adding vtrunk; bugs need to be verified in the trunk for eventual limbo checkins.
Status: RESOLVED → ASSIGNED
Keywords: vtrunk

Comment 16

17 years ago
Clearing resolution, nsBranch bugs should be closed only after checkins into
limbo builds.
Resolution: FIXED → ---

Comment 17

17 years ago
Commercial builds
2001-07-05-09-trunk/ win nt 4.0
2001-07-05-08-trunk/ linux 2.2, red hat 7.0
2001-07-05-08-trunk/ mac os 9.0.4

While offline and going to file menu and selecting
Send Unsent Messages this is what I observed:
  -Send Unsent messages isn't disabled (which is ok)
  -Instead a new window pops up
    * A Send Messages window (with a question mark ballon icon)
      It says "You are currently offline. Would you like
      to go online and send your unsent messages?"
    * 2 buttons appear
      -Go online (emphasis is placed on this button as it
       has dark outline)
       Note: it says "Go online", not sure if the "o" should
             be a capital "O" or small "o". But based on
             screen shot from bug 79865, this is ok.
      -cancel button

Clicking Go online results in going online and/or usent messages
being sent. Obvioulsy if there are no messages to be sent,
nothing happens other than going online. 
Clicking Cancel results in still being offline and no messages
being sent.


Verified on trunk.

Removing Keyword Vtrunk.

adding 'verified on trunk' to status whiteboard.

Leaving status as Assigned per instructions from Jussi.
   
Keywords: vtrunk
Whiteboard: fixed by 79865 → fixed by 79865, verified on trunk

Comment 18

17 years ago
We're past the point where this could get a PDT+.  This won't make it onto the
branch.

Comment 19

17 years ago
Missed 0.9.3.
Target Milestone: mozilla0.9.3 → mozilla0.9.4
(Assignee)

Comment 20

17 years ago
changing the resolution to fixed, 
since it is checked into the trunk;
(Assignee)

Comment 21

17 years ago
changing the resolution to fixed, 
since it is checked into the trunk;
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED

Comment 22

17 years ago
Verified with Commercial builds:

2001082809 - win nt 4.0
2001082808 - linux 2.2, mac 9.0.4

While offline and there is an unsent message in Unsent folder, go to file menu 
and select "Send Unsent Messages" results:

   * A dialog box pop up with two buttons:
         - Go Online
         - Cancel         
     and says "You are currently offline.  
     Would you like to go onlineand send your unsent messages?"
   * Clicking online results in going onine and sent the unsent message
   * Clicking cancel won't take any action and stay offline

If there is no unsent message in the Unsent folder, the File|Send Unsent 
Messages is disabled.

Gary, I don't have the privelege to change the bug's status field, can you mark 
the bug as Verified for me? thx.

Comment 23

17 years ago
marking as verified
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.