Bypass getUserMedia permissions with a pref

VERIFIED FIXED in mozilla18

Status

()

Core
WebRTC: Audio/Video
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: anant, Assigned: anant)

Tracking

Trunk
mozilla18
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
A preference to bypass permissions for gUM would be very useful. Additionally, permissions are being (incorrectly) asked for fake streams.
(Assignee)

Updated

5 years ago
Summary: Bypass permissions with a pref → Bypass getUserMedia permissions with a pref
(Assignee)

Comment 1

5 years ago
Created attachment 668959 [details] [diff] [review]
Add pref to disable permission check
Assignee: nobody → anant
Status: NEW → ASSIGNED
Attachment #668959 - Flags: review?(rjesup)
Comment on attachment 668959 [details] [diff] [review]
Add pref to disable permission check

Ok, and this fixes the permission request for fake media streams bug as well.

Can I say I hate the names we chose for getUserMedia preffing?  Luckily they (or at least media.navigator.enabled) will go away eventually.  :-)

r+

No privacy review needed since the getUserMedia is preffed off currently.  When preffed on, we'd need to run this by privacy.
Attachment #668959 - Flags: review?(rjesup) → review+

Updated

5 years ago
Attachment #668959 - Attachment is patch: true
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/959de7eea1ff
(In reply to Anant Narayanan [:anant] from comment #0)
> A preference to bypass permissions for gUM would be very useful.
> Additionally, permissions are being (incorrectly) asked for fake streams.

Anant, just a note here. Why are those incorrectly shown? At least for the testing mode we need those notifications, otherwise nothing can be tested. So I would vote for that we do not remove them.
https://hg.mozilla.org/mozilla-central/rev/959de7eea1ff
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
(In reply to Henrik Skupin (:whimboo) from comment #4)
> Anant, just a note here. Why are those incorrectly shown? At least for the
> testing mode we need those notifications, otherwise nothing can be tested.
> So I would vote for that we do not remove them.

As a workaround tests can enable the pref for testing purposes. So I think we are fine here.
(Assignee)

Comment 7

5 years ago
Just to be clear, the pref is to *disable* the permission dialog, not enable it. The default is (of course) to always ask for permission.

Updated

5 years ago
Keywords: verifyme
Verified in 10/12 Nightly build.
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.