Compile error: calDateTime.cpp(636) and calDateTime.cpp(641) : error C2660: 'js_DateIsValid' / 'js_DateGetMsecSinceEpoch' : function does not take 2 arguments

RESOLVED FIXED in 2.0

Status

Calendar
Internal Components
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aryx, Assigned: Fallen)

Tracking

Trunk
x86
Windows XP
Dependency tree / graph

Details

Attachments

(1 attachment)

According to Fallen, this is likely fallout from bug 794477.

When building Lightning on Thunderbird-Try with JavaScript-only changes, I got a compile error, see https://tbpl.mozilla.org/php/getParsedLog.php?id=15915536&tree=Thunderbird-Try :

Many of these kind:
c:\tools\msvs10\vc\include\xutility(3412) : warning C4273: 'std::moz_Xruntime_error' : inconsistent dll linkage

        e:\builds\moz2_slave\tb-try-c-cen-w32\build\objdir-tb\mozilla\dist\include\mozilla\msvc_raise_wrappers.h(30) : see previous definition of 'moz_Xruntime_error'

And then these:
e:/builds/moz2_slave/tb-try-c-cen-w32/build/calendar/base/src/calDateTime.cpp(636) : error C2660: 'js_DateIsValid' : function does not take 2 arguments

e:/builds/moz2_slave/tb-try-c-cen-w32/build/calendar/base/src/calDateTime.cpp(641) : error C2660: 'js_DateGetMsecSinceEpoch' : function does not take 2 arguments

e:/builds/moz2_slave/tb-try-c-cen-w32/build/calendar/base/src/calDateTime.cpp(641) : fatal error C1903: unable to recover from previous error(s); stopping compilation
(Assignee)

Updated

5 years ago
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Component: Calendar Views → Internal Components

Comment 1

5 years ago
It is caused by Bug 793076 that removed the second parameter from that functions with todays checkin.

Updated

5 years ago
Depends on: 793076
(Assignee)

Comment 2

5 years ago
Created attachment 669119 [details] [diff] [review]
Fix - v1

Looks like I was coding against an old version of the API, or I have no idea why it was compiling. I've just updated mozilla-central, did a full rebuild and with these changes it works.
Attachment #669119 - Flags: review?(matthew.mecca)
(Assignee)

Comment 3

5 years ago
(In reply to Stefan Sitter from comment #1)
> It is caused by Bug 793076 that removed the second parameter from that
> functions with todays checkin.
Ah ok, then I wasn't all wrong :-P Stefan, if you'd like to review this patch instead feel free to!

Updated

5 years ago
Attachment #669119 - Flags: review?(matthew.mecca) → review+
(Assignee)

Comment 4

5 years ago
Pushed to comm-central changeset ae6b83c2a3c0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0
You need to log in before you can comment on or make changes to this bug.