Closed Bug 799071 Opened 8 years ago Closed 8 years ago

Clean up -Werror failures from clang on linux in media/webrtc/signaling

Categories

(Core :: WebRTC: Signaling, defect)

x86_64
Linux
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla19
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: decoder, Assigned: jesup)

References

Details

(Keywords: sec-want, Whiteboard: [asan-build-blocker] [qa-])

Attachments

(1 file, 7 obsolete files)

Seeing this on the ASan builds right now (likely not ASan but Clang specific):

/builds/slave/try-lnx64/build/media/webrtc/signaling/src/sipcc/core/ccapp/ccapi_snapshot.c:396:29: error: implicit conversion from enumeration type 'cc_reg_state_t' to different enumeration type 'cc_service_cause_t' [-Werror,-Wconversion]
   g_deviceInfo.ins_cause = CC_CREATED_IDLE;
                          ~ ^~~~~~~~~~~~~~~
1 error generated.
make[7]: Leaving directory `/builds/slave/try-lnx64/build/obj-firefox/media/webrtc/signaling/signaling_sipcc'
make[7]: *** [src/sipcc/core/ccapp/ccapi_snapshot.o] Error 1
make[6]: *** [signaling_sipcc_libs] Error 2
Checked the source, and this is indeed a bug. Did you mean to use CC_CAUSE_NONE?
yes, that looks correct (though this value is pretty irrelevant unless something has failed).
Summary: webrtc/signaling/src/sipcc/core/ccapp/ccapi_snapshot.c: implicit conversion from enumeration type 'cc_reg_state_t' to different enumeration type 'cc_service_cause_t → Clean up -Werror failures from clang on linux in media/webrtc/signaling
Component: WebRTC → WebRTC: Signaling
WIP patch pending more reports
Attachment #669124 - Attachment is obsolete: true
Attachment #669125 - Attachment is obsolete: true
QA Contact: general → jsmith
The OSX build (clang) had -Wno-error=conversion specified in signaling.gyp to suppress these.  Should we remove that now that they are fixed?
Duplicate of this bug: 799158
Attachment #669159 - Attachment is obsolete: true
Comment on attachment 669205 [details] [diff] [review]
clean up clang warnings in media/webrtc/signaling (-Werror)


Looks good to me.  I'll try it out on OSX clang.
Attachment #669205 - Flags: review+
Sorry, try again - missed one because I modified the wrong repo
Attachment #669205 - Attachment is obsolete: true
Attachment #669212 - Attachment is obsolete: true
Attachment #669228 - Attachment is obsolete: true
Attachment #669229 - Attachment is obsolete: true
Attachment #669236 - Flags: review?(ethanhugg)
decoder and ddahl both verify this works on linux clang; ehugg tested it on OS/X clang.
Comment on attachment 669236 [details] [diff] [review]
clean up clang warnings in media/webrtc/signaling (-Werror)

Review of attachment 669236 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me.
Attachment #669236 - Flags: review?(ethanhugg) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/680ad178dafa
Once we're green we'll go to Aurora, akeybl already gave a= in IRC
Duplicate of this bug: 798738
Duplicate of this bug: 799478
https://hg.mozilla.org/mozilla-central/rev/680ad178dafa
Assignee: nobody → rjesup
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Whiteboard: [asan-build-blocker] → [asan-build-blocker] [qa-]
You need to log in before you can comment on or make changes to this bug.