Closed
Bug 799071
Opened 12 years ago
Closed 12 years ago
Clean up -Werror failures from clang on linux in media/webrtc/signaling
Categories
(Core :: WebRTC: Signaling, defect)
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: decoder, Assigned: jesup)
References
Details
(Keywords: sec-want, Whiteboard: [asan-build-blocker] [qa-])
Attachments
(1 file, 7 obsolete files)
16.99 KB,
patch
|
ehugg
:
review+
|
Details | Diff | Splinter Review |
Seeing this on the ASan builds right now (likely not ASan but Clang specific): /builds/slave/try-lnx64/build/media/webrtc/signaling/src/sipcc/core/ccapp/ccapi_snapshot.c:396:29: error: implicit conversion from enumeration type 'cc_reg_state_t' to different enumeration type 'cc_service_cause_t' [-Werror,-Wconversion] g_deviceInfo.ins_cause = CC_CREATED_IDLE; ~ ^~~~~~~~~~~~~~~ 1 error generated. make[7]: Leaving directory `/builds/slave/try-lnx64/build/obj-firefox/media/webrtc/signaling/signaling_sipcc' make[7]: *** [src/sipcc/core/ccapp/ccapi_snapshot.o] Error 1 make[6]: *** [signaling_sipcc_libs] Error 2
Reporter | ||
Comment 1•12 years ago
|
||
Checked the source, and this is indeed a bug. Did you mean to use CC_CAUSE_NONE?
Assignee | ||
Comment 2•12 years ago
|
||
yes, that looks correct (though this value is pretty irrelevant unless something has failed).
Assignee | ||
Updated•12 years ago
|
Summary: webrtc/signaling/src/sipcc/core/ccapp/ccapi_snapshot.c: implicit conversion from enumeration type 'cc_reg_state_t' to different enumeration type 'cc_service_cause_t → Clean up -Werror failures from clang on linux in media/webrtc/signaling
Assignee | ||
Updated•12 years ago
|
Component: WebRTC → WebRTC: Signaling
Assignee | ||
Comment 3•12 years ago
|
||
WIP patch pending more reports
Assignee | ||
Comment 4•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #669124 -
Attachment is obsolete: true
Assignee | ||
Comment 5•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #669125 -
Attachment is obsolete: true
QA Contact: general → jsmith
Comment 6•12 years ago
|
||
The OSX build (clang) had -Wno-error=conversion specified in signaling.gyp to suppress these. Should we remove that now that they are fixed?
Assignee | ||
Comment 8•12 years ago
|
||
try this patch
Assignee | ||
Updated•12 years ago
|
Attachment #669159 -
Attachment is obsolete: true
Comment 9•12 years ago
|
||
Comment on attachment 669205 [details] [diff] [review] clean up clang warnings in media/webrtc/signaling (-Werror) Looks good to me. I'll try it out on OSX clang.
Attachment #669205 -
Flags: review+
Assignee | ||
Comment 10•12 years ago
|
||
Sorry, try again - missed one because I modified the wrong repo
Assignee | ||
Updated•12 years ago
|
Attachment #669205 -
Attachment is obsolete: true
Assignee | ||
Comment 11•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #669212 -
Attachment is obsolete: true
Assignee | ||
Comment 12•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #669228 -
Attachment is obsolete: true
Assignee | ||
Comment 13•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #669229 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Attachment #669236 -
Flags: review?(ethanhugg)
Assignee | ||
Comment 14•12 years ago
|
||
decoder and ddahl both verify this works on linux clang; ehugg tested it on OS/X clang.
Comment 15•12 years ago
|
||
Comment on attachment 669236 [details] [diff] [review] clean up clang warnings in media/webrtc/signaling (-Werror) Review of attachment 669236 [details] [diff] [review]: ----------------------------------------------------------------- looks good to me.
Attachment #669236 -
Flags: review?(ethanhugg) → review+
Assignee | ||
Comment 16•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/680ad178dafa Once we're green we'll go to Aurora, akeybl already gave a= in IRC
Assignee | ||
Comment 18•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/680ad178dafa
Comment 20•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/680ad178dafa
Assignee: nobody → rjesup
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Assignee | ||
Comment 21•12 years ago
|
||
Landed on Aurora, a=akeybl in IRC https://hg.mozilla.org/releases/mozilla-aurora/rev/fa9a4d400949
Updated•12 years ago
|
status-firefox18:
--- → fixed
status-firefox19:
--- → fixed
Updated•12 years ago
|
Whiteboard: [asan-build-blocker] → [asan-build-blocker] [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•