Closed
Bug 799089
Opened 13 years ago
Closed 12 years ago
Remove error console filter timeout hack
Categories
(Toolkit Graveyard :: Error Console, defect)
Toolkit Graveyard
Error Console
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla22
People
(Reporter: neil, Assigned: Cykesiopka)
References
Details
Attachments
(1 file)
|
9.22 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
The Error Console's filter setter applies the filter on a timeout. Now that (as of bug 799084) the filter is only set on a timeout, it would seem to me as if the filter can be applied inline to the setter.
I also notice that there is no corresponding getter for completeness.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #730515 -
Flags: review?(neil)
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 730515 [details] [diff] [review]
Proposed Patch v1
[The blank line whitespace fixes tend to obscure the actual change...]
Attachment #730515 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Ah, sorry about that: I'll avoid it in the future...
|
||
Comment 4•12 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
|
||
Updated•9 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•