Closed Bug 799089 Opened 12 years ago Closed 11 years ago

Remove error console filter timeout hack

Categories

(Toolkit Graveyard :: Error Console, defect)

Product:
Toolkit Graveyard
Component:
Error Console
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla22

People

(Reporter: neil, Assigned: Cykesiopka)

References

Details

Attachments

(1 file)

Proposed Patch v1
9.22 KB, patch
neil
: review+
Details | Diff | Splinter Review 
The Error Console's filter setter applies the filter on a timeout. Now that (as of bug 799084) the filter is only set on a timeout, it would seem to me as if the filter can be applied inline to the setter.

I also notice that there is no corresponding getter for completeness.

        Attachment #730515 -
        Flags: review?(neil)

    
    

    
  
Comment on attachment 730515 [details] [diff] [review]
Proposed Patch v1

[The blank line whitespace fixes tend to obscure the actual change...]

        Attachment #730515 -
        Flags: review?(neil) → review+

    
    

    
  
Ah, sorry about that: I'll avoid it in the future...
Assignee: nobody → cykesiopka
Status: NEW → ASSIGNED
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/db5c1742af26
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Product: Toolkit → Toolkit Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: