799103 - We should have AutoLocks/Mutexes in mfbt so they're usable outside of libxul

Status: REOPENED

(Core :: MFBT, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

Even if we lose some functionality, we should have a standard set of AutoLock/MutexAutoLock-type functions for non-libxul code, perhaps that uses 'normal' MutexAutoLock if it is in xul.  This has bitten us a bunch of times before we gave up and moved webrtc/signaling to XUL, and in c++ unit tests for webrtc. We could also find a way to expose enough functionality from xul to allow the non-xul versions to keep all the checks in MutexAutoLock, which would be even better.

Also handy anytime we want to move code from xul to gkmedia

Comment 1

[Eric Rescorla (:ekr)]

Waldo,

Any thoughts here?

Comment 2

[Jeff Walden [:Waldo]]

Seems reasonable enough.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Thoughts? Still relevant? (going through old bugs I filed)

Comment 5

[Mike Hommey [:glandium]]

My bad, PlatformMutex doesn't have autolocks. It might be worth adding some there (moving them from e.g. xpcom), and share them around (with e.g. the profiler).