If anyone would like to work on this, the code generating this error is here. We probably just need to make sure this code isn't run before this.input is set. http://hg.mozilla.org/projects/elm/file/503aba7760ad/browser/metro/base/content/bindings/autocomplete.xml#l255 For help building and running Metro Firefox, see: https://wiki.mozilla.org/Firefox/Windows_8_Integration
Summary: error starting up metro: chrome://browser/content/bindings/autocomplete.xml → [Metro] Error message in JS console during startup: chrome://browser/content/bindings/autocomplete.xml: this.input is null
Component: Untriaged → General
Product: Firefox → Firefox for Metro
Version: unspecified → Trunk
This error is probably happening when this constructor calls gridBoundCallback, which calls updateResults: http://hg.mozilla.org/projects/elm/file/503aba7760ad/browser/metro/base/content/bindings/grid.xml#l260 That code was added here in bug 792901. We should make sure not to regress that bug while fixing this one.
Created attachment 702346 [details] [diff] [review] patch This is safe and it silences the warning, but if anyone has a clever idea for how to restructure this code so that updateResults isn't called too early/often, that'd be great too.
Assignee: nobody → mbrubeck
Attachment #702346 - Flags: review?(sfoster)
Comment on attachment 702346 [details] [diff] [review] patch Review of attachment 702346 [details] [diff] [review]: ----------------------------------------------------------------- I think this probably is good enough for now. We could have some init / if(this._inited) flag, but actually we might want to revisit this whole thing later once the richgrid / tile group is done so I think even that isn't worth it right now
Attachment #702346 - Flags: review?(sfoster) → review+
Status: NEW → ASSIGNED
Whiteboard: [mentor=mbrubeck][lang=js] → [completed-elm]
Resolving bugs in the Firefox for Metro product that are fixed on the elm branch. Sorry for the bugspam. Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.