Closed Bug 799332 Opened 7 years ago Closed 7 years ago

Set a high urlclassifier.updateinterval to match the one in automation.py.in so that we're unlikely to leak background safebrowsing updates by doing them at the wrong time

Categories

(Testing :: Reftest, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla19

People

(Reporter: philor, Assigned: philor)

Details

Attachments

(1 file)

Attached patch fix v.1Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=15941344&full=1&branch=mozilla-inbound#error0 is a crashtest run whose leaked URLs include https://sb-ssl.google.com/safebrowsing/newkey?client=navclient-auto-ffox&appver=19.0a1&pver=2.2

We lack the handy prefable server that automation.py has to set things like browser.safebrowsing.keyURL to something we know will 404 instantly and locally, but setting the updateinterval high enough ought to save us anyway, I think.
Attachment #669393 - Flags: review?(dbaron)
Comment on attachment 669393 [details] [diff] [review]
fix v.1

r=dbaron
Attachment #669393 - Flags: review?(dbaron) → review+
Landed in https://hg.mozilla.org/integration/mozilla-inbound/rev/fb167937d25b, backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/f0f1d1dac953 - I can't believe I copy-pasted the automation.py user_pref() and didn't switch to branch.setIntPref().
Er, I suppose I should have noticed that too.

r=dbaron with the obvious fix, anyway.
https://hg.mozilla.org/mozilla-central/rev/be4dd7c430af
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.