799440 - Building blocks rules should not conflict with each other

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P2)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

E.g., the confirm.css and the action_menu.css conflicts in
https://github.com/mozilla-b2g/gaia/blob/master/shared/style/action_menu.css#L74 https://github.com/mozilla-b2g/gaia/blob/master/shared/style/confirm.css#L71


Now the only application would use most styles in building blocks is system app.
It's a big pain if they have conlicts, because system app itself is too huge to be modified according to unstable BB...


c.c. @fabi1cazenave

Comment 1

[Fabien Cazenave [:kaze]]

see https://github.com/mozilla-b2g/gaia/pull/5726

I think the only way to avoid these conflicts is to use specific class names. I propose:
 • `.dialog-action`: title + action selection + accept/dismiss buttons
 • `.dialog-confirm`: message + accept/dismiss buttons
 • `.dialog-edit`: edition panel with dialog-like button toolbar
 • `.dialog-object`: action selection + accept/dismiss buttons

We could also use a `.role-*` prefix instead (or any other prefix that would make sense), and apply this prefix to the danger/recommend button classes.

Comment 2

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

Comment 3

[Fabien Cazenave [:kaze]]

https://github.com/fabi1cazenave/gaia/commit/ae7e8a532df111dc1826d312c32f63ee84750fba

Comment 4

[Fabien Cazenave [:kaze]]

FTR, we use a `data-type` attribute rather than `dialog-*` class names.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Reopened for it's reverted in https://github.com/mozilla-b2g/gaia/pull/5771 . The original change causes RIL data connection failure as described in bug 800267.

Comment 6

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

Comment 7

[Etienne Segonzac (:etienne)]

Funny to say that on a BB patch, but 3G is working well!

Comment 8

[Fabien Cazenave [:kaze]]

:-)

Comment 9

[Dietrich Ayala (:dietrich)]

Blocking+. If we're shipping the BBs, we must ship them working correctly, since they'll also be used by 3rd party app devs for the lifetime of the v1 product.

Comment 10

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/pull/5790