move xpconnect chrome mochitests in tests/mochitest to tests/chrome

RESOLVED FIXED in mozilla19

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: foudil.newbie+bmo, Assigned: foudil.newbie+bmo)

Tracking

18 Branch
mozilla19
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 5 obsolete attachments)

(Assignee)

Description

6 years ago
js/xpconnect/tests/mochitest/Makefile.in has a MOCHITEST_CHROME_FILES section, whereas chrome mochitests should be in js/xpconnect/tests/chrome/.
(Assignee)

Updated

6 years ago
Assignee: nobody → foudil.newbie+bmo
(Assignee)

Comment 1

6 years ago
Created attachment 669594 [details] [diff] [review]
patch v0

test_bug760131.html, previously referenced as a chrome test, is obviously a plain mochitest.
Attachment #669594 - Flags: review?(bobbyholley+bmo)
(Assignee)

Comment 2

6 years ago
Created attachment 669595 [details] [diff] [review]
sorting MOCHITEST_FILES

while at it, here is my attempt to sort MOCHITEST_FILES.

I'll merge both patches appropriately.
Maybe we should just merge those folders.
Comment on attachment 669594 [details] [diff] [review]
patch v0

test_bug760131.html is actually a chrome test, even though it's not a .xul file. So it shouldn't be moved to MOCHITEST_FILES.
Attachment #669594 - Flags: review?(bobbyholley+bmo) → review-
(Assignee)

Comment 5

6 years ago
Created attachment 673330 [details] [diff] [review]
patch v1

got it ! Here is a new patch with light sorting of MOCHITEST_FILES in tests/mochitest/Makefile.in included.
Attachment #669594 - Attachment is obsolete: true
Attachment #669595 - Attachment is obsolete: true
Attachment #673330 - Flags: review?(bobbyholley+bmo)
Hm, why do file_bug795275.html and such move up in the list? Can we keep everything in sorted order according to bug number? (that is to say, test_123 and file_123 together).
(Assignee)

Comment 7

6 years ago
Created attachment 673357 [details] [diff] [review]
patch v2 -- another try

not easy to keep everything sorted according to bug number since file naming is not consistent, but here is another try.
Attachment #673330 - Attachment is obsolete: true
Attachment #673330 - Flags: review?(bobbyholley+bmo)
Attachment #673357 - Flags: review?(bobbyholley+bmo)
Comment on attachment 673357 [details] [diff] [review]
patch v2 -- another try

test_bug361111.xul never gets removed from the other list here as far as I can tell.

Maybe first do a patch that just moves the mochitest-chrome files, and then a second patch that does the sorting?
Attachment #673357 - Flags: review?(bobbyholley+bmo) → review-
(Assignee)

Comment 9

6 years ago
Created attachment 673412 [details] [diff] [review]
patch v3 -- part 1 - Move
Attachment #673357 - Attachment is obsolete: true
Attachment #673412 - Flags: review?(bobbyholley+bmo)
(Assignee)

Comment 10

6 years ago
Created attachment 673416 [details] [diff] [review]
patch v3 -- part 2 - Sorting
Attachment #673416 - Flags: review?(bobbyholley+bmo)
Comment on attachment 673412 [details] [diff] [review]
patch v3 -- part 1 - Move

r=bholley
Attachment #673412 - Flags: review?(bobbyholley+bmo) → review+
Comment on attachment 673416 [details] [diff] [review]
patch v3 -- part 2 - Sorting

Erg, hrm - doesn't appear to be sorted? Stuff like file_mozMatchesSelector.html is mixed in with the other stuff.

Basically, the stuff with the bug numbers in it should all be together, sorted by bug number, and everything else should be alphabetical. Sorry if that was unclear, and that this is turning out to be so finicky. :-(
Attachment #673416 - Flags: review?(bobbyholley+bmo) → review-
(Assignee)

Comment 13

6 years ago
Created attachment 673431 [details] [diff] [review]
patch v4 -- part 2 - Sorting

Oh I see. I previously put file_mozMatchesSelector.html btw. file_bug505915.html and test_bug553407.html because it was related to bug 533596. But a visual sorting makes sense.
Attachment #673416 - Attachment is obsolete: true
Attachment #673431 - Flags: review?(bobbyholley+bmo)
Comment on attachment 673431 [details] [diff] [review]
patch v4 -- part 2 - Sorting

parfait ;-) r=bholley
Attachment #673431 - Flags: review?(bobbyholley+bmo) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f0fd262da49b
https://hg.mozilla.org/mozilla-central/rev/8d0616db8d20
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.