Closed Bug 799709 Opened 7 years ago Closed 7 years ago

b2g mochitests should by default load an sdcard of size 10MB

Categories

(Testing :: Mochitest, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla21

People

(Reporter: onecyrenus, Assigned: onecyrenus)

Details

Attachments

(1 file, 1 obsolete file)

B2g mochitests should by default load an sdcard. 

Currently no sdcard is loaded, which makes it difficult to run deviceStorage based tests, or any tests that require the usage of deviceStorage. 

The downside to loading an sdcard is minimum.
David, is there a particular image required for our tests, or just any card will do?
Setup a default sdcard size of 10MB this will allow device storage tests to run correctly.
Attachment #709914 - Flags: review?(jgriffin)
Summary: b2g mochitests should by default load an sdcard → b2g mochitests should by default load an sdcard of size 10MB
Geo, basically in bug: 790546 we did the plumbing, but never set a default value.  However now we are setting the default value to 10MB, so as to activate the feature.
The patch looks OK, but I have a feeling it will fail on the test slaves due to lack of mksdcard.  Pushing to try to test this theory out:

https://tbpl.mozilla.org/?tree=Try&rev=c6677b9bf3f5
Attachment #709914 - Attachment is patch: true
18:11:49     INFO - Running command: ['/home/cltbld/talos-slave/test/build/venv/bin/python', '/home/cltbld/talos-slave/test/build/tests/mochitest/runtestsb2g.py', '--adbpath', '/home/cltbld/talos-slave/test/build/emulator/b2g-distro/out/host/linux-x86/bin/adb', '--b2gpath', '/home/cltbld/talos-slave/test/build/emulator/b2g-distro', '--console-level', 'INFO', '--emulator', 'arm', '--logcat-dir', '/home/cltbld/talos-slave/test/build', '--remote-webserver', '10.0.2.2', '--run-only-tests', 'b2g.json', '--xre-path', '/home/cltbld/talos-slave/test/build/xre/bin', '--total-chunks', '6', '--this-chunk', '1', '--gecko-path', '/home/cltbld/talos-slave/test/build/application/b2g', '--busybox', '/home/cltbld/talos-slave/test/build/busybox'] in /home/cltbld/talos-slave/test/build/tests/mochitest
18:11:49     INFO - Copy/paste: /home/cltbld/talos-slave/test/build/venv/bin/python /home/cltbld/talos-slave/test/build/tests/mochitest/runtestsb2g.py --adbpath /home/cltbld/talos-slave/test/build/emulator/b2g-distro/out/host/linux-x86/bin/adb --b2gpath /home/cltbld/talos-slave/test/build/emulator/b2g-distro --console-level INFO --emulator arm --logcat-dir /home/cltbld/talos-slave/test/build --remote-webserver 10.0.2.2 --run-only-tests b2g.json --xre-path /home/cltbld/talos-slave/test/build/xre/bin --total-chunks 6 --this-chunk 1 --gecko-path /home/cltbld/talos-slave/test/build/application/b2g --busybox /home/cltbld/talos-slave/test/build/busybox
18:11:49     INFO -    File "/home/cltbld/talos-slave/test/build/tests/mochitest/runtestsb2g.py", line 120
18:11:49     INFO -      defaults["sdcard"] = 10MB
18:11:49     INFO -                              ^
18:11:49     INFO -  SyntaxError: invalid syntax
Fixed the syntax error and pushed to try again:

https://tbpl.mozilla.org/?tree=Try&rev=ab233d7163ea
Attachment #709914 - Attachment is obsolete: true
Attachment #709914 - Flags: review?(jgriffin)
Ahh oops yes, i just caught this, this a.m as well..
Attachment #711436 - Flags: review?(jgriffin)
Attachment #711436 - Flags: review?(jgriffin) → review+
Component: Mozmill Automation → Mochitest
Product: Mozilla QA → Testing
https://hg.mozilla.org/mozilla-central/rev/652167093cc5
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.