Closed Bug 799717 Opened 7 years ago Closed 7 years ago

Avoid using PR_BEGIN_EXTERN_C and PR_END_EXTERN_C in mcom_db.h

Categories

(NSS :: Libraries, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

Follow-up from bug 795507.
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #669744 - Flags: review?(bsmith)
Kai, if this is a part of NSS, then why does it live in /dbm in the source tree, instead of security/dbm?

It seems like at one point in time, Gecko might have been using dbm for stuff. But, is it still using dbm now? If not, maybe we should just reorganize the NSS CVS repository to merge /dbm to security/dbm?
The answer to my question in comment 2 is in the bugs listed in the "see also" section.

Ehsan, did you see bug 795507 comment 15? Why do you think this change helps with the Gecko code cleanup projects, when no Gecko code includes this header?

It seems like a better solution would be to move dbm under security/, as proposed in the bugs in the "see also" section, and then treat all of NSS consistently.
Status: ASSIGNED → UNCONFIRMED
Ever confirmed: false
See Also: → 301249, 318173
(In reply to Brian Smith (:bsmith) from comment #3)
> Ehsan, did you see bug 795507 comment 15? Why do you think this change helps
> with the Gecko code cleanup projects, when no Gecko code includes this
> header?

I have.  But Kai asked me to attach the patch here in the next comment.  :-)

> It seems like a better solution would be to move dbm under security/, as
> proposed in the bugs in the "see also" section, and then treat all of NSS
> consistently.

It doesn't really matter a lot to me whether NSS takes this patch or not, so please feel free to r- it if you don't want to accept it.  And as far as the location of dbm code goes, why not just put it under security/nss?
Comment on attachment 669744 [details] [diff] [review]
Patch (v1)

Review of attachment 669744 [details] [diff] [review]:
-----------------------------------------------------------------

Ehsan, I will ask about moving dbm/ to be under security/ at the NSS meeting tomorrow.
Attachment #669744 - Flags: review?(bsmith)
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Ehsan: sorry to have wasted your time. I agree that mcom_db.h
doesn't need to be patched.
(In reply to comment #6)
> Ehsan: sorry to have wasted your time. I agree that mcom_db.h
> doesn't need to be patched.

No worries, took no more than 5 seconds.  :-)
You need to log in before you can comment on or make changes to this bug.