799761 - "Show sidebar" checkmark does not reflect the current sidebar state

Status: RESOLVED WORKSFORME

(Firefox Graveyard :: SocialAPI, defect)

Description

[Matthew N. [:MattN]]

The checkmark only reflects the value at startup, not after being toggled at runtime.

STR:
1) Click "Show sidebar" under the provider's menu

Expected results:
The visibility of the menuitem checkmark should be toggled

Actual results:
The visibility is not toggled.


It seems like the event listener code is supposed to toggle the checked state.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-social.js#882 should be updating the checked state.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Can't repro this and haven't seen it, but FWIW bug 800210 also mentions some strangeness around that menu item/checkmark.

Comment 3

[Matthew N. [:MattN]]

I still saw this two days ago on OS X if the sidebar was off at startup.

Comment 4

[Shane Caraveo (:mixedpuppy)]

I have this right now in aurora, but I cannot force it to happen in my dev build.  Toggling my sidebar again fixed the check state.

I don't think I restarted with the sidebar off, and trying that did not reproduce it.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

I can't repro on Aurora.  Maybe some obscure mac-only issue?

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

I am seeing this right now on 17.0b2

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

(In reply to Lukas Blakk [:lsblakk] from comment #6)
> I am seeing this right now on 17.0b2

On OS X 10.8

Comment 8

[Andrew McCreight [:mccr8]]

I'm seeing this too, on OS X 10.6 with Nightly.  The check mark under "Tools > Facebook Messenger for Nightly" is correctly checked, but the one you get when you click on the little FB icon in the toolbar does not change state. That is the case no matter which method I use to open the sidebar.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

We need to chase down why this is happening - I've looked at the code involved and can't figure out how this could happen, short of some XUL command broadcasting failures.

Comment 11

[Shane Caraveo (:mixedpuppy)]

unable to reproduce in 18.

Comment 12

[Matthew N. [:MattN]]

Still happening on today's Nightly for me: 21.0a1 (2013-01-08) on OS X 10.7.5

Comment 13

[Shane Caraveo (:mixedpuppy)]

I still cannot make it happen, same build/os.  However, the "show desktop notifications" checked menuitem does not work for me.

Comment 14

[Justin Dolske [:Dolske]]

I have the same thing as comment 8 -- works in the Tools menu, but not in the toolbar button's menu.

Comment 15

[Shane Caraveo (:mixedpuppy)]

(In reply to Shane Caraveo (:mixedpuppy) from comment #13)
> I still cannot make it happen, same build/os.  However, the "show desktop
> notifications" checked menuitem does not work for me.

frustrating, now I cannot get either of those menus to fail again.  fx19.

Comment 16

[Justin Dolske [:Dolske]]

I'm on a current OS X nightly. The bug persists across browser restarts, but only seems to manifest if I start the browser with the sidebar hidden. I don't see anything in the error console. Oddly, it started working (before my I had even restared), after showing/hiding it a few times. But that doesn't seem a reliable, I just did that again but it's staying broken.

Comment 17

[u279076]

Is this still reproducible for anyone?

Comment 18

[Matthew N. [:MattN]]

Yes

Comment 19

[u279076]

I still can't reproduce this. Shane or Gavin, is there any information Matthew can provide which might help in chasing this down?

Comment 20

[Shane Caraveo (:mixedpuppy)]

I can no longer repro.  I think the updates that included the sidebar toolbar button may have nixed it.