Send puppet reports from AWS puppet masters to puppet dashboard

RESOLVED FIXED

Status

Infrastructure & Operations
CIDuty
RESOLVED FIXED
6 years ago
2 months ago

People

(Reporter: rail, Assigned: rail)

Tracking

Details

(Whiteboard: [puppet][aws])

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Per http://docs.puppetlabs.com/dashboard/manual/1.2/bootstrapping.html#using-dashboard-for-reports we need the following in puppet.conf
[master]
 reports = store, http
 reporturl = http://dashboard.example.com:3000/reports/upload

Probably would be great to puppetize this.
In our case, it's

    reports = tagmail, http
    reporturl = http://puppetdash.pvt.build.mozilla.org/reports/upload
(Assignee)

Comment 3

6 years ago
Created attachment 669955 [details] [diff] [review]
[WIP] reports

Not tested
Looks good, but whats this?
+$extlookup_precedence = ["domain_%{domain}", "local-config", "default-config", "secrets"]
(Assignee)

Comment 5

6 years ago
(In reply to Dustin J. Mitchell [:dustin] from comment #4)
> Looks good, but whats this?
> +$extlookup_precedence = ["domain_%{domain}", "local-config",
> "default-config", "secrets"]

Probably I should drop that and use local-config instead for master specific customizations. Wanted to have something generic for aws masters, but probably it'll be harder to read/follow the configs in this case.
(Assignee)

Comment 6

6 years ago
Created attachment 670380 [details] [diff] [review]
reports

I tested this with 'puppet apply .. --noop --show_diff --diff diff --diff_args "-u" ...'. The diff looks quite sane:

Default:

+    reports = tagmail
+    reporturl = http://dashboard.example.com:3000/reports/upload

and

+    reports = tagmail,http
+    reporturl = http://puppetdash.pvt.build.mozilla.org/reports/upload

if I put the following into local-config:
puppet_server_reports,"tagmail,http"
puppet_server_reporturl,http://puppetdash.pvt.build.mozilla.org/reports/upload
Attachment #669955 - Attachment is obsolete: true
Attachment #670380 - Flags: review?(dustin)
Comment on attachment 670380 [details] [diff] [review]
reports

Review of attachment 670380 [details] [diff] [review]:
-----------------------------------------------------------------

Cool, looks good!

::: manifests/extlookup/default-config.csv
@@ +11,5 @@
>  crl_sync_url,
>  puppet_again_repo,http://hg.mozilla.org/build/puppet
>  global_authorized_keys,
> +puppet_server_reports,tagmail
> +puppet_server_reporturl,http://dashboard.example.com:3000/reports/upload

This example should probably be blank?  I don't think we want to accidentally send reports to example.com :)
Attachment #670380 - Flags: review?(dustin) → review+
(Assignee)

Comment 8

6 years ago
Comment on attachment 670380 [details] [diff] [review]
reports

http://hg.mozilla.org/build/puppet/rev/4ffe43d3857a

(In reply to Dustin J. Mitchell [:dustin] from comment #7) 
> This example should probably be blank?  I don't think we want to
> accidentally send reports to example.com :)

I changed that to "http://localhost:3000/reports/upload" which is default per http://docs.puppetlabs.com/references/latest/configuration.html#reporturl
Attachment #670380 - Flags: checked-in+
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering

Updated

2 months ago
Product: Release Engineering → Infrastructure & Operations
You need to log in before you can comment on or make changes to this bug.