799891 - tools/lib/python/signing/client.py needs "Automation Error:" indications on failures

Status: RESOLVED INCOMPLETE

(Release Engineering :: General, defect, P4)

Description

[Mark Banner (:standard8)]

Failures such as

2012-10-08 02:43:47,443 - 3395fa97544068444c86a330eb5bf9407569e3e8: processing Daily.app.tar.gz on https://mac-signing2.srv.releng.scl3.mozilla.com:9110
2012-10-08 02:43:47,463 - 3395fa97544068444c86a330eb5bf9407569e3e8: uploading for signing
2012-10-08 02:43:54,232 - 3395fa97544068444c86a330eb5bf9407569e3e8: error uploading file for signing: File too large
2012-10-08 02:43:55,234 - 3395fa97544068444c86a330eb5bf9407569e3e8: giving up after 20 tries

Should have the lines include "Automation Error:". This way tbpl can pick them up more easily and developers don't have to load the full log to know what went wrong.

Comment 1

[[e-mail] (:bhearsum)]

It's debatable whether these are automation errors or not. Sometimes this is indicative of problems in the build system (eg, packaging code not cleaning up properly).

Comment 2

[Ed Morley [:emorley]]

I'd like to avoid adding hundreds more strings to tbpl's regex if possible.

If "Automation Error" doesn't apply in this case, we should come up with an appropriate prefix we can use throughout build-system+test-harnesses+buildbot+tbpl, for this and other similar errors, rather than having to continually add edge cases to:

https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/file/86df15508bf3/php/inc/GeneralErrorFilter.php
and
https://hg.mozilla.org/build/buildbotcustom/file/f0a1f5209ced/status/errors.py
and
https://raw.github.com/mozilla/mozharness/master/mozharness/base/errors.py
and
...

Comment 3

[[e-mail] (:bhearsum)]

I don't really care what string we match. I'm just pointing out that however we do catch this, making it purple probably won't be correct all the time.

Comment 4

[Chris AtLee [:catlee]]

I agree with Ben. Using Automation Error for this error condition could be misleading....although we generally just bump the file size when we hit this :\