799998 - [Gallery] Edit Mode - Effects Polish

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Gallery, defect, P3)

Description

[Patryk Adamczyk [:patryk] UX]

The highlight should be blue on each effect. Currently the highlight chnages colour with effect, turns gray on the BW and turns brown on the sepia.


1. What are the values used for Black and White? We can tweak these to make more dramatic / better looking BW photos?
2. What are the values used for Sepia? We can tweak these to make more dramatic / better looking photos.

Comment 1

[David Flanagan [:djf]]

That's a known bug that I probably forgot to file.  I was surprised to learn that CSS effects apply to the entire element, including its border...  I'll have to figure out a workaround for that.

I'm not sure what "values" you're looking for for the BW and Sepia transforms.  Here are the matrices I'm using:

ImageProcessor.sepia_matrix = [
  0.393, 0.769, 0.189, 0,
  0.349, 0.686, 0.168, 0,
  0.272, 0.534, 0.131, 0,
  0, 0, 0, 1
];

ImageProcessor.bw_matrix = [
  .333, .333, .333, 0,
  .333, .333, .333, 0,
  .333, .333, .333, 0,
  0, 0, 0, 1
];

Is that what you're looking for?

Comment 2

[Patryk Adamczyk [:patryk] UX]

Thanks David,
Sepia seems to perform fine. I'd like to increase the contrast in BW, also optimize the colour for skin tones. Can you use these values instead:
.65, .25, .10, 0,
.65, .25, .10, 0,
.65, .25, .10, 0,
0, 0, 0, 1

Also since we have 3 options but have room for 5, I was hoping we can add further colour effects.

Fashion High Contrast... "Blue Steel"
1, .25, .65, 0,
.1, 1, .65,  0,
.1, .25, 1, .1,
0, 0, 0, 1

Faded Photo
1, .2, .2, .03,
.2, .7, .2, .05, 
.1, 0, .8, 0,
0, 0, 0, 1

I attached examples of how they will look.

Comment 3

[Patryk Adamczyk [:patryk] UX]

Attachment: blue steel

Comment 4

[Patryk Adamczyk [:patryk] UX]

Attachment: Black and White

Comment 5

[Patryk Adamczyk [:patryk] UX]

Attachment: Original (no effects)

Comment 6

[Patryk Adamczyk [:patryk] UX]

Attachment: Faded Photo

Comment 7

[David Flanagan [:djf]]

Patryk,

It should be easy to add these two new effects. The three current effects have text labels "Original", "B & W", "Sepia".  What labels do you want for the other two?  "Fade" and "Steel"?

Actually, we're past string freeze, so I don't know what the procedure for getting new strings localized would be.  Given that with 5 effects the font size would have to shrink, should we just remove the text?  Is the visual itself enough?

Comment 8

[Patryk Adamczyk [:patryk] UX]

Since we only have 5 effects (no effect carrousel),  I'd prefer no label for the effects. Also the words would be clipped with the thinner thumbnails (since we have 5 across now, not 3)
I'd order them <original><bw><sepia><steel><fade>

Comment 9

[Aditya Bhatt [:adityab]]

Added https://github.com/mozilla-b2g/gaia/pull/5780

Comment 10

[David Flanagan [:djf]]

Patryk: your fade matrix seems to make yellow images more yellow, and they end up looking enhanced rather than faded. Are you okay with that?

Aditya: r+ on your pull request #5780. Let's try to get that landed and handled the hightlight colors in a separate patch.

Comment 11

[Patryk Adamczyk [:patryk] UX]

(In reply to David Flanagan [:djf] from comment #10)
> Patryk: your fade matrix seems to make yellow images more yellow, and they
> end up looking enhanced rather than faded. Are you okay with that?

With the limited effects we have, I think its okay. I will need to do some "dog fooding" as we get this feature in, and still may do some tweaks based on the camera output.

Comment 12

[Patryk Adamczyk [:patryk] UX]

Attachment: Thanks for making the change, but looks like something is off, I don't think the Black and White looks correct, and the blue filter is really blown out and not blue...

Comment 13

[Patryk Adamczyk [:patryk] UX]

Does this look correct in the desktop emulator and just not on the device?

Comment 14

[Patryk Adamczyk [:patryk] UX]

(In reply to Patryk Adamczyk [:patryk] UX from comment #13)
> Does this look correct in the desktop emulator and just not on the device?

Tried it out on an Unagi, looks just as bad. Can you show me where the file is, I'll do some tests.

Comment 15

[David Flanagan [:djf]]

I've checked and double checked the matrices. I've rotated them, and I've swapped rows and columns. Nothing makes them work the way you want.  Are these matrices from photoshop? I wonder if we're just talking different matrix languages here. Maybe your matrices just aren't compatible with my algorithms.

Should we just remove the bluesteel and fade options until we can figure it out?

Comment 16

[Patryk Adamczyk [:patryk] UX]

I'll play around with this for LEO. See if I can come up with better matrices.

Comment 17

[Lukas Blakk [:lsblakk] use ?needinfo]

Mass edit to set tracking-b2g18+ for these UX bugs that were called out for v1.1

Comment 18

[Stephany Wilkes]

Any updates on this one for 1.1?

Comment 19

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Question: since this is a broad topic of Effects polish:
Should the effects -> original -> checkmark create a duplicate picture?

It seems odd to me to have that allow to duplicate a picture.

Comment 20

[Patryk Adamczyk [:patryk] UX]

Working on a plan with Rob, to improve the overall gallery app filters. I think the current engine is not as accurate as we'd like anyway.

Comment 21

[Amy Lee [:amylee] UX]

Is it possible we can bring this back up for review? The quality of the filters in the current gallery app can definitely be improved.

Comment 22

[David Flanagan [:djf]]

Bulk edit to clear old and out of date needinfo requests that I never responded to. I'm assuming that these are no longer relevant. If you are still waiting for an answer from me, please set needinfo? again.

Comment 23

[BMO Automation]

Firefox OS is not being worked on