Closed Bug 800002 Opened 9 years ago Closed 8 years ago

[Gallery] Edit Mode - Exposure Polish

Categories

(Firefox OS Graveyard :: Gaia::Gallery, defect, P3)

All
Other
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: padamczyk, Assigned: sjochimek)

Details

(Keywords: polish, Whiteboard: visual design, visual-tracking)

Attachments

(3 files)

Can you please make the slide match the visual design: https://www.dropbox.com/s/771lbuva8lb2hij/Gallery_Edit_Exposure_A_120720.jpg
I cannot match that kind of thing by eye. It looks to me like you've got a gray gradient, but I can't tell what it is. And I have no idea how I'd do the 'groove' of the slider with CSS.  If you give me an image to use as the slider background, I can use that. Or if you give me precise specs on the background color, I can use those.  But without details I'm just going to screw around and get something that looks okay to me and probably looks terrible to you. 

Also, the draggable part of the slider is too small to reliably grab as you've designed it, so I'll have to make the touch-sensitive area of it bigger than the visible area.
Attached image Crop Spec
Added a spec for the new crop tool. Cut up all the graphics here:
https://www.dropbox.com/sh/grmnjr3eqexfkur/O3wIoOPD4X

Hope this helps!
Component: Gaia → Gaia::Gallery
David, just checked the latest gaia/master build (12-03-2013).  It doesn't look like this has been implemented yet.  What's the status on this? Let me know if you need any more details or specs, thanks!
Flags: needinfo?(dflanagan)
I don't think I need anything more except more time to work on stuff like this. This would be a good bug for someone else to take...
Flags: needinfo?(dflanagan)
Assignee: dflanagan → sjochimek
Hi Sam, have you started work on this bug? Let me know, thanks!
Flags: needinfo?(sjochimek)
Whiteboard: visual design → visual design, visual-tracking
Attached file PR Github
Flags: needinfo?(sjochimek)
Attached image After patch screenshot
Attachment #760437 - Flags: feedback?(epang)
Comment on attachment 760437 [details]
After patch screenshot

This looks good. Thanks Sam!
Attachment #760437 - Flags: feedback?(epang) → feedback+
Attachment #760436 - Flags: review?(dale)
Comment on attachment 760436 [details]
PR Github

As its gallery, passing review along to David
Attachment #760436 - Flags: review?(dale) → review?(dflanagan)
Comment on attachment 760436 [details]
PR Github

There are some nits on github that I'd like you to address, but overall the patch seems to work fine, and I'm giving r+.

It seems to me that the slider line and the vertical tick marks lines are too faint to see well in bright light, but that's a visual design issue.

Also: by changing the background color from gray to black, you basically break the two black border options, so please file a followup bug to remove those border options.  Perhaps we should just have four options for four different white border widths? We'll need to consult with visual design, I suppose.
Attachment #760436 - Flags: review?(dflanagan) → review+
Hey Sam, what happened with this?  Are we able to land this?
Flags: needinfo?(sjochimek)
Landed in master: https://github.com/mozilla-b2g/gaia/commit/474e067e2ad26d5ce97a052a681fee92273e3a16
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(sjochimek)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.