800087 - Deleted versions should still be listed under Version History

Status: RESOLVED FIXED

(Marketplace Graveyard :: Reviewer Tools, enhancement, P3)

Description

[krupa raj[:krupa]]

When a developer deletes a rejected app version, the related info is removed from Reviewer Tools-> Version History.

It might be useful for editors to have a complete track of all the versions of an app.

Comment 1

[Rob Hudson [:robhudson]]

Andrew, could you comment on how useful this is, or where/how to display data about deleted versions?

Since we actually delete these from the database, we lose the info in the reviewer logs which link to the version. I don't have an idea yet on how to do this in a nice and simple way.

Comment 2

[Andrew Williamson [:eviljeff]]

It is useful to have a complete audit trail of reviews.  With Add-ons there were many occasions where missing review information led to duplication of effort (if not actual security vulnerabilities).  

Its the scenario of 'a developer getting rejected for something unsafe, deleting the version rejected and then repeating until they're lucky enough to catch a reviewer who makes a mistake and overlooks the issue' we're trying to stop.

With Add-ons the reviews do show up in the review history now so maybe its possible to duplicate how it works on AMO?  (I've not looked into either implementation)

Comment 3

[Andrew Williamson [:eviljeff]]

found this during a trawl of outstanding bugs ... with privileged apps creating potential security issues I feel this should be higher than a P4 enhancement.

This might be a dupe/connected to bug 834572.

Comment 4

[Caitlin Galimidi [:c8o]]

Wil - What do you think of Andrew's comment ^^ ? I'm on board. When is your next triage with David & team and assign to sprint or backlog? Hiieeeee-yah!

Comment 5

[Rob Hudson [:robhudson]]

Example of what we're shooting for on Marketplace:
https://addons.mozilla.org/en-US/editors/review/site-navigation-bar

Also see bug 666987 for the AMO equivalent.

Comment 7

[Matt Basta [:basta]]

Should be done here, waiting on krupa for confirmation.

https://github.com/mozilla/zamboni/commit/3d2c962f167ff5d6b3178dee353b9d363d858daf

Please close if you can confirm that it's working as expected and my concept of the patch matches up with the general consensus of how this is supposed to work.

Comment 8

[Wil Clouser [:clouserw]]

thanks!